Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources #1013

developerkunal · 2024-08-29T06:06:21Z

🔧 Changes

Deprecated: Resource: auth0_prompt_partials
Implemented: Resource: auth0_prompt_screen_partials, auth0_prompt_screen_partials
Added: Data Source: auth0_prompt_screen_partials
Added examples for the new data sources, resource imports, and resource usage.

📚 References

🔬 Testing

Added test cases for creating, deleting, and updating the auth0_prompt_screen_partial and auth0_prompt_screen_partials resource.
Added data source tests for validation and data retrieval.

📝 Checklist

All new/changed/fixed functionality is covered by tests (or N/A).
Documentation has been added for all new/changed functionality (or N/A).

codecov-commenter · 2024-08-29T06:09:51Z

Codecov Report

Attention: Patch coverage is 89.79058% with 39 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (f156db8) to head (ac84625).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/auth0/prompt/resource_screen_partial.go	87.70%	10 Missing and 5 partials ⚠️
internal/auth0/prompt/resource_screen_partials.go	90.90%	6 Missing and 3 partials ⚠️
...ternal/auth0/prompt/data_source_screen_partials.go	77.77%	4 Missing and 2 partials ⚠️
internal/auth0/prompt/expand.go	88.00%	4 Missing and 2 partials ⚠️
internal/auth0/prompt/flatten.go	95.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.02%     
==========================================
  Files         109      112       +3     
  Lines       14601    14983     +382     
==========================================
+ Hits        13177    13520     +343     
- Misses       1008     1034      +26     
- Partials      416      429      +13

Files with missing lines	Coverage Δ
internal/auth0/prompt/resource_partials.go	`91.42% <100.00%> (+2.53%)`	⬆️
internal/provider/provider.go	`100.00% <ø> (ø)`
internal/auth0/prompt/flatten.go	`87.87% <95.00%> (+10.95%)`	⬆️
...ternal/auth0/prompt/data_source_screen_partials.go	`77.77% <77.77%> (ø)`
internal/auth0/prompt/expand.go	`91.54% <88.00%> (-8.46%)`	⬇️
internal/auth0/prompt/resource_screen_partials.go	`90.90% <90.90%> (ø)`
internal/auth0/prompt/resource_screen_partial.go	`87.70% <87.70%> (ø)`

…ials

acwest · 2024-09-04T14:11:32Z

some of the insertion points should get better test coverage, if you can,

internal/auth0/prompt/data_source_screen_partials_test.go

internal/auth0/prompt/resource_screen_partial.go

internal/auth0/prompt/resource_screen_partials.go

duedares-rvj · 2024-09-05T08:22:05Z

Minor comments. Rest looks good to me.

…n_partials` in Prompt Resources (auth0#1013) * Add-Support-for-Prompt-Screen-Partials * Add auth0_prompt_screen_partial Resource and Required Docs * Fix Linting * Updated Go-auth0 Version 1.9.0 to 1.10.0 * Added Testcases for other insertionpoints as well * Fixed Linting * Added More testcases * Correct depends on for datasource of prompt partials

…n_partials` in Prompt Resources (auth0#1013) * Add-Support-for-Prompt-Screen-Partials * Add auth0_prompt_screen_partial Resource and Required Docs * Fix Linting * Updated Go-auth0 Version 1.9.0 to 1.10.0 * Added Testcases for other insertionpoints as well * Fixed Linting * Added More testcases * Correct depends on for datasource of prompt partials Signed-off-by: BryanLewis-AtOkta <[email protected]>

… for Verify. Patch: Removed MinItems validation for precedence on Connection Resource (auth0#1017) * Removed min/max validation on precendence slice * reverted maxItems validation Add support for all languages for Universal Login (auth0#1016) * Fetch list of languages from CDN instead of hardcoding them * Updated linting --------- Co-authored-by: KunalOfficial <[email protected]> Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources (auth0#1013) * Add-Support-for-Prompt-Screen-Partials * Add auth0_prompt_screen_partial Resource and Required Docs * Fix Linting * Updated Go-auth0 Version 1.9.0 to 1.10.0 * Added Testcases for other insertionpoints as well * Fixed Linting * Added More testcases * Correct depends on for datasource of prompt partials Bump github.com/hashicorp/terraform-plugin-testing from 1.9.0 to 1.10.0 (auth0#999) Bumps [github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-testing/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-testing@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-testing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add Organizations for Client Credentials (auth0#1009) * Updated schema and added relevant test cases for client with default_organization * Added test recordings * Updated the resource schema and added new test recordinging * Added validation on required arguments * Fixed linting and updated test recording * Deleted a test recording * Updated go.mod Add Sorting to `screen_partials` Flattening Logic to Resolve Indexing Issues with Prompt Screen Partials (auth0#1019) * Change screen_partials to TypeSet for consistent ordering in prompt screen partials * Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues Add changelog for v1.6.0 (auth0#1020) * Added the changelog * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> --------- Co-authored-by: KunalOfficial <[email protected]> Patch: default_organization on Client Creds (auth0#1021) * Updated flow of importing default_organization * Updated logic for handling default Orgs * Updated test recordings * Updated the conditional check Add changelog for v1.6.1 (auth0#1022) * Added changelog * linting fixes * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> --------- Co-authored-by: KunalOfficial <[email protected]> Add HRI related changes to Terraform provider (auth0#1015) * Add HRI related changes to Terraform provider * Fix broken HasChange behaviour * Change ConflictWith to explicit validation in code * Move validation to plan instead of apply * Fix validation for default resources Add strategy_version support to all connections that use it (auth0#1024) * ESD-39527: Add strategy_version support to all connections that use it * Update go-auth0 dependency * Add examples for strategy_version Add user_id_attribute support to AzureAD connection options (auth0#1028) Add user_id_attribute to AzureAD connection options Bump github.com/auth0/go-auth0 from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0 (auth0#1036) Bump github.com/auth0/go-auth0 Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.10.1-0.20240920131149-720c3a081e03 to 1.11.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](https://github.com/auth0/go-auth0/commits/v1.11.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Added some minor updates Updated recordings docs updated Add auth0_encryption_keys resource to allow rekeying of encryption keys (auth0#1031) * Add auth0_encryption_key resource to allow rekeying of tenant encryption keys * Slight renaming, and use key_rotation_id instead of rekey attribute * Rename auth0_encryption_key to auth0_encryption_key_manager Add new resource to manage Organization Client Grants (auth0#1027) * Added new resource and data source for org client grants * minor refactoring * Added test case * Updated test recordings * Updated the test name * Fix some timing issues in resourceserver, and add terraform version to server logs * Remove unneeded lint config * rebased * minor refactoring * Added test case * Updated test recordings * Updated the test name * Fix some timing issues in resourceserver, and add terraform version to server logs * Remove unneeded lint config --------- Co-authored-by: A. Craig West <[email protected]> Add support for Form, Flow and Flow Vault Connection (auth0#1039) * form resource * flow resource * flow resource, data source added * update forms * update flow * update go-auth0 v1.11.0 * added flow vault connection * Added flow expand/flatten + tests + recordings * update flow vault connection * form, flow vault connection added unit test, recordings * form, flow vault connection doc update * form, flow vault connection examples added * form, flow vault connection examples added example, data source * form, flow vault connection examples docs updated * lint fix * form, flow unit test added * form flatten unit test added * lint * Updated recordings --------- Co-authored-by: kushalshit27 <[email protected]> PATCH: Ensure Removal of Insertion Points in `auth0_prompt_screen_partial` Resource (auth0#1043) Fix: Ensure Removal of Insertion Points in Resource API Support BYOK in Terraform provider (auth0#1041) Co-authored-by: KunalOfficial <[email protected]> Bump github.com/auth0/go-auth0 from 1.11.0 to 1.11.1 (auth0#1042) Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add changelog for 1.7.0 (auth0#1044) * Added changelog for 1.7.0 * Added further changes * removed . * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * removed . * minor refactor --------- Co-authored-by: KunalOfficial <[email protected]> Fix docs for user_id_attribute for AzureAD connection options (auth0#1047) ESD-40277: Fix docs for user_id_attribute for AzureAD connection options PATCH: Add graceful error handling for `auth0_organization` data source when using client grants (auth0#1049) * Added check on tenants which has insufficient scopes and return a empty slice * Updated test case * minor refactoring * minor refactor * linting * linting Updated example for Form (auth0#1046) * Updated example for form PATCH: Implemented checkpoint pagination for retrieving Role users (auth0#1048) * Implemented checkpoint pagination on role users * added tests Add changelog for 1.7.1 (auth0#1050) * Added changelog * refac * refac * refac * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * Added changelog * refac * refac * refac * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * refac * Apply suggestions from code review Co-authored-by: KunalOfficial <[email protected]> * Added changelog * refac * refac * refac * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> * refac * Added changelog * Update CHANGELOG.md Co-authored-by: KunalOfficial <[email protected]> --------- Co-authored-by: KunalOfficial <[email protected]> Fix: Updated `TestAccConnectionAzureAD` test recording (auth0#1052) Updated recording + auth0 version bump Added a check on provider's configuration for required env vars (auth0#1053) * Added a check on provider's configuration for reqd env vars * Added linting

Add-Support-for-Prompt-Screen-Partials

4a3cdf4

developerkunal changed the title ~~Add Support for Prompt Screen Partials~~ Add Support for Prompt Screen Partials Aug 29, 2024

developerkunal marked this pull request as ready for review August 29, 2024 06:51

developerkunal requested a review from a team as a code owner August 29, 2024 06:51

Add auth0_prompt_screen_partial Resource and Required Docs

6152cc0

developerkunal changed the title ~~Add Support for Prompt Screen Partials~~ Add Support for auth0_prompt_screen_partial and auth0_prompt_screen_partials in Prompt Resources Sep 4, 2024

developerkunal added 3 commits September 4, 2024 15:00

Fix Linting

e2eab4e

Merge branch 'main' into DXCDT-695-Add-Support-for-Prompt-Screen-Part…

68ef66c

…ials

Updated Go-auth0 Version 1.9.0 to 1.10.0

48d40be

developerkunal added 3 commits September 4, 2024 20:23

Added Testcases for other insertionpoints as well

fb3b5a1

Fixed Linting

f40261f

Added More testcases

c3a8456

duedares-rvj reviewed Sep 5, 2024

View reviewed changes

internal/auth0/prompt/data_source_screen_partials_test.go Show resolved Hide resolved

duedares-rvj reviewed Sep 5, 2024

View reviewed changes

internal/auth0/prompt/resource_screen_partial.go Outdated Show resolved Hide resolved

duedares-rvj reviewed Sep 5, 2024

View reviewed changes

internal/auth0/prompt/resource_screen_partials.go Outdated Show resolved Hide resolved

Correct depends on for datasource of prompt partials

ac84625

duedares-rvj approved these changes Sep 5, 2024

View reviewed changes

developerkunal merged commit b026516 into main Sep 5, 2024
9 checks passed

developerkunal deleted the DXCDT-695-Add-Support-for-Prompt-Screen-Partials branch September 5, 2024 08:55

developerkunal mentioned this pull request Sep 6, 2024

Add Sorting to screen_partials Flattening Logic to Resolve Indexing Issues for Prompt Screen Partials #1019

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources #1013

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources #1013

developerkunal commented Aug 29, 2024 •

edited

Loading

codecov-commenter commented Aug 29, 2024 •

edited

Loading

acwest commented Sep 4, 2024

duedares-rvj commented Sep 5, 2024

Add Support for auth0_prompt_screen_partial and auth0_prompt_screen_partials in Prompt Resources #1013

Add Support for auth0_prompt_screen_partial and auth0_prompt_screen_partials in Prompt Resources #1013

Conversation

developerkunal commented Aug 29, 2024 • edited Loading

🔧 Changes

📚 References

🔬 Testing

📝 Checklist

codecov-commenter commented Aug 29, 2024 • edited Loading

Codecov Report

acwest commented Sep 4, 2024

duedares-rvj commented Sep 5, 2024

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources #1013

Add Support for `auth0_prompt_screen_partial` and `auth0_prompt_screen_partials` in Prompt Resources #1013

developerkunal commented Aug 29, 2024 •

edited

Loading

codecov-commenter commented Aug 29, 2024 •

edited

Loading