Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity lacks access_token_secret #41

Closed
joshua-pevner opened this issue Feb 24, 2017 · 2 comments
Closed

Identity lacks access_token_secret #41

joshua-pevner opened this issue Feb 24, 2017 · 2 comments

Comments

@joshua-pevner
Copy link

The Twitter identity provides both an access_token and access_token_secret in its Identity. Both of these values are necessary when doing third-party auth with Twitter. Unfortunately, the current Identity class only provides the access_token field. Preferably, another field would be added for access_token_secret.

@lbalmaceda
Copy link
Contributor

Hi @joshua-pevner
Thanks for reporting this. I've submitted a PR that parses the extra fields to a Map.

@joshua-pevner
Copy link
Author

That's awesome, thank you.

@lbalmaceda lbalmaceda added this to the v1-Next milestone Mar 15, 2017
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.1.0 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants