You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I modified https://github.com/Autarc/optimal-select/blob/master/src/match.js#L259 locally to use nth-of instead of nth-child and it works great across multiple sites. Do you have any objections to incorporating this change directly in match.js as opposed to a later optimization in optimize.js. I will be happy to send a pull request if you think the change seems worthy and don't want to take it on yourself.
The text was updated successfully, but these errors were encountered:
At first I thought about using the nth-type-of selector in the initial matching as well - the problem is that its doesn't work in every case. For validation and comparison a simplified version of the css-selector-generator-benchmark is used. If you apply the generalization too early some tests will fail. Therefore the nth-child selector is used as the default fallback.
I modified https://github.com/Autarc/optimal-select/blob/master/src/match.js#L259 locally to use nth-of instead of nth-child and it works great across multiple sites. Do you have any objections to incorporating this change directly in match.js as opposed to a later optimization in optimize.js. I will be happy to send a pull request if you think the change seems worthy and don't want to take it on yourself.
The text was updated successfully, but these errors were encountered: