Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron Window opens, yet, NO Forza data transmitting to window. #70

Open
ltorrespr opened this issue Feb 11, 2024 · 9 comments
Open

Comments

@ltorrespr
Copy link

Describe the bug
The Electron window opens with all the elements within the window, yet, when I check on the "View/Toggle Developer Tools", it provides and error of "react-dom.development.js:67 Warning: validateDOMNesting(...): cannot appear as a child of

. Add a , or to your code to match the DOM tree generated by the browser." at Line 67 of the "react-dom.development.js" file inside the "react-dom/cjs" directory.

I have not been able to figure this issue out, though I spent much time with my friend Google..lol...!

To Reproduce
Steps to reproduce the behavior:

  1. npm run build:react | npm run build | npm run start
  2. Click on 'View/Toggle Developers Tools'
  3. Errors and Warnings are displayed on bottom, along with information on the culprit file(s).

Expected behavior
A expect that the data from Forza would be transmitted to and rendered by Electron.

Screenshots

Screenshot 2024-02-11 at 2 09 14 PM

Desktop (please complete the following information):

  • OS: MacOS Sonoma 14.2.1
  • Game: Forza Motorsport 2023

Additional context

I have used the RECORD button on the Electron window, yet, when I go to the *.csv file, only the titles of the Data Out from Forza are within the file (thus, no data). Not sure if the error explained above will address this data receiving/recording part of the SW package.

@jeremySchriver
Copy link

What output style are you using? Dash format with the new Forza changed a bit and needs to be handled in the data_packet file.

Screenshot 2024-02-11 191513
Screenshot1 2024-02-11 191811
Screenshot2 2024-02-11 191929

@jeremySchriver
Copy link

Sorry forgot to capture a method in my first comment
Screenshot3 2024-02-11 192325

@ltorrespr
Copy link
Author

ltorrespr commented Feb 12, 2024

Hi Jeremy, thank you very much for looking into this.

I am using the "Car Dash" format (Data Out Packet Format) on my FM settings.

I will check that file.

Again, thank you!

======================
hmmm....can't seem to find that. I will search several sub-Dir's to see if I can come up with that file.

@ltorrespr
Copy link
Author

Just realized you were talking about the project you pulled together, and not what Austin has developed which is what I am currently using. However, does seem your pulling together some pretty cool stuff for the "backend" in order to get access to the Telemetry data. Thanks!

@jeremySchriver
Copy link

Just realized you were talking about the project you pulled together, and not what Austin has developed which is what I am currently using. However, does seem your pulling together some pretty cool stuff for the "backend" in order to get access to the Telemetry data. Thanks!

I'm so sorry I got myself a bit mixed up. I was thinking that I had branched from Austin's project so assumed my work of getting it running with FM8 would work for you. My project is actually python based rather than JS and C based but I believe the issue remains the same. FM8 changed the data packet format and added 5 new values to the dash output packet. It appears that Austin already made a switch for this new format in the code but I don't see the new values available in the dataPacket class.

Here are the new values directly from the Forza data out documentation
image

Looking at Austin's code the data packet formatting ends at the driving assist lines even when under the new FM8 format
image

@austinbaccus please let us know if we are off base or are missing something here.

@ltorrespr
Copy link
Author

Thanks Jeremy! Your response explains it spot on! I will take a look this file and edit for some testing. Will let you know if it works.

I am also wondering if these 5 new data elements are also set somewhere else.

@ltorrespr
Copy link
Author

Just made the edits to the DataPacket.cs file and proceeded to perform a fresh "npm install", followed by the run command "". It still has the same issue, and, the data file is empty (only including column headers).

Screenshot 2024-02-14 at 8 43 29 AM Screenshot 2024-02-14 at 8 46 23 AM

@jeremySchriver
Copy link

It appears that there is also data packet information in the following files

  • FMData.cs
  • Program.cs

I would venture to guess you would need to add similar lines in each of those files to get it running. However, being unfamiliar with cs I'm a bit unsure of where else to dig for dependencies.

@ltorrespr
Copy link
Author

ltorrespr commented Feb 16, 2024

I will give that a try, thank you! I am also unfamiliar with cs.....just learning & troubleshooting.

*** Update: I added the additional missing code lines to both files (FMData.cs & Program.cs), yet, still with the same problem as described in mu first post. And, *.csv file capturing the "live" telemetry is empty (only headers).

I'll keep researching (my friend Google) to see if there is something I can do to get rid of those errors, then, be able to focus on the telemetry data in & out to the *csv file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants