Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad syntax highlighting with certain patterns #6

Closed
Flatta opened this issue Oct 10, 2016 · 3 comments
Closed

Bad syntax highlighting with certain patterns #6

Flatta opened this issue Oct 10, 2016 · 3 comments
Assignees
Labels

Comments

@Flatta
Copy link

Flatta commented Oct 10, 2016

I'm submitting a bug report

  • VSCode Version:
    1.5.3
  • Library Version:
    0.1.5
  • Operating System:
    Windows 10

I noticed that bad syntax highlighting occurs not only with referrer but also with some patterns.
Patterns I found are listed below.

  • Begins with show, if, view-model, repeat.for
  • Begins with bindable, controller (with no following - or ! or ...)
  • Contains .bind, .one-way, .two-way, .one-time

Current behavior:
image

<template>
  <E A="show">         </E>
  <E A="if">           </E>
  <E A="view-model">   </E>
  <E A="repeat.for">   </E>
  <E A="bindable.">    </E>
  <E A="controller.">  </E>
  <E A="x.bind">       </E>
  <E A="x.one-way">    </E>
  <E A="x.two-way">    </E>
  <E A="x.one-time">   </E>
</template>
@eriklieben
Copy link
Contributor

Thanks for testing it so thoroughly.

I fixed the regex code to behave correctly in these cases, but require some more time to write tests cases for them. Otherwise, I break something again by fixing something else :-)

Will let you know when a fix is ready.

@EisenbergEffect
Copy link
Contributor

Sounds good.

On Oct 11, 2016, at 1:42 PM, Erik Lieben [email protected] wrote:

Thanks for testing it so thoroughly.

I fixed the regex code to behave correctly in these cases, but require some more time to write tests cases for them. Otherwise, I break something again by fixing something else :-)

Will let you know when a fix is ready.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
, or mute the thread
.

@eriklieben
Copy link
Contributor

@Flatta if you upgrade to v0.1.7 the above issue is resolved, I had some issues publishing to the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants