Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version breaks HTML formatting functionality #45

Closed
doronguttman opened this issue May 3, 2017 · 6 comments
Closed

Latest version breaks HTML formatting functionality #45

doronguttman opened this issue May 3, 2017 · 6 comments
Assignees

Comments

@doronguttman
Copy link

I'm submitting a bug report

  • Extension Version:
    major.minor.patch-pre

Please tell us about your environment:

  • Operating System:
    OSX 10.x|Linux (distro)|Windows [7|8|8.1|10]

  • Visual studio code version:
    0.3.2

HTML/JS/TS of incorrect highlight
any HTML

Current behavior:
Pressing Alt-Shift-F does not format the document; the format document option is gone from the command pallet when in an HTML file. Also, any other HTML extension and snippets are not working as well. When disabling the extension it works again.

Expected/desired behavior:

Reproduce:

  1. create a new workspace
  2. disable all extensions for workspace
  3. create HTML file
  4. see that file is formatted when doing Format Document (Alt-Shift-F)
  5. Enable extension
  6. see that file is NOT formatted and that Format Document is not available in command pallet
@kuechlerm
Copy link

I can see that html files have now the language mode "aurelia HTML" by default.

Why is this necessary? Now I have to pick between aurelia-syntax support and formatting.

@bryceg
Copy link

bryceg commented May 4, 2017

This also breaks any icon packs such as "vscode-icons"

@Lichtjaeger
Copy link

It also breaks script block and style block syntax highlighting.

@eriklieben
Copy link
Contributor

Thanks for the feedback.

Will look into this tonight, might need to remove the custom language again and let it override the default html so plugins/ tools for html stay working.

@tetious
Copy link

tetious commented May 4, 2017

This also breaks tag pair (<div></div>) highlighting to suss out those giant div sandwiches. :)

@eriklieben eriklieben self-assigned this May 4, 2017
@eriklieben
Copy link
Contributor

eriklieben commented May 4, 2017

Everything is set back to HTML, I think all the above issues are resolved with that. Version 0.3.3 is released.

The custom hover provider with MDN info and Aurelia info is disabled for now, working on a fix for that here: https://github.com/aurelia/vscode-extension/tree/fix-hover-provider but that takes a bit longer and a quick fix for this issue could not wait for this I think.

Sorry for the inconvenience, wanted to get a release out to fast and didn't notice this in the test environment on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants