Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): move to usage of SnippetString new in vscode 1.8.0 #28

Merged
merged 3 commits into from
Dec 19, 2016

Conversation

eriklieben
Copy link
Contributor

No description provided.

@eriklieben eriklieben merged commit a438cb5 into master Dec 19, 2016
@bigopon
Copy link
Member

bigopon commented Dec 19, 2016

May I know how I'm supposed to use this feature please ? I have no ideas what it's useful for.

@eriklieben
Copy link
Contributor Author

eriklieben commented Dec 19, 2016

hmm, I might have wrongly tagged this after thinking about it. First wanted to go with re-factor, but that didn't feel good because logic is changing (this version only works in vscode 1.8.0 and up). Sorry for the confusion.

Visual Studio Code is deprecating the old way in which we could provide auto-complete because they now support the more generic TextMate snippets syntax (https://manual.macromates.com/en/snippets).
For the full discussion, see this: microsoft/vscode#3210

This pull request is a quick move over to that implementation of providing snippets, so that autocomplete doesn't stop working when the vscode team remove the now depreciated logic.
So from the user's point of view, not much is changing, the auto-complete should still work the same.

I am working on a new implementation to improve the auto-complete once and for all (which includes the snippet string logic), so that is better extensible, but that is not completed yet.

Then I am also able to easily add the logic you proposed in #18. And add back in support to get completions on the dot, like it used to work in vscode before 1.6.0. So for example, by default you would get value.bind="" as autocomplete option (less overhead by default), if you move to the dot, you get the extra options (one-way, two-way, one-time). Or you could just add an extra dot behind a normal attribute, like value. to get the binding options.

Once this is done I can update the screenshots/ videos of how things work and then we are back on stable grounds.

@bigopon
Copy link
Member

bigopon commented Dec 19, 2016

Sounds great. Tks for your hard work 😄

@eriklieben eriklieben deleted the snippetstring-upgrade branch January 8, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants