Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Titles Truncated at first dot #2

Closed
nurbles opened this issue Mar 23, 2019 · 2 comments
Closed

Book Titles Truncated at first dot #2

nurbles opened this issue Mar 23, 2019 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@nurbles
Copy link

nurbles commented Mar 23, 2019

I just noticed in my output folder that book titles that contain a dot end just before the dot. So, for example, I have "The Collected Works of Arthur C" instead of "The Collected Works of Arthur C. Clarke".

Looking deeper, I see that titles that should end with "(unabridged)" are missing that word and the parenthesis and the one title I have that contains a colon ends just before the colon. I kinda understand that one, since a colon is an illegal file name character, but I would prefer it to be replaced with a dash (or some other legal character.)

Again, I know this is a new work and has only recently been released, I'm "beating it up" and reporting what I find in the hope that this changes from a really good tool into a GREAT tool!

@nurbles
Copy link
Author

nurbles commented Mar 23, 2019

Oh, this could be especially troubling for volumes in a series that all end with "Vol. N" because removing the volume number would make all the titles the same!

@audiamus
Copy link
Owner

The dot should be accepted as a valid title punctuation mark indeed.

However, you can already customize this, in the Basic Settings dialog, via the system menu. You can also, if you want to, add the parentheses there.

But there is some intention behind this behaviour. The title is parsed for non-essential i.e. meta information, and such elements are to be removed, to make it as short as possible. The parsing is very simple at the moment, looking for punctuation marks. My default use case is listening to the audiobook on my car radio and the radio display shows the title tag with a limited number of characters allowed.

As there are other use cases, I will add more customization options here. Users may want to have the series title included which is usually separated with a colon. But sometimes the series title is left and sometimes right of the book title. This will be taken care of.

And I will add free text customization on an individual file basis, for author(s) and title. That can also solve the long path issue. (The control I want to use for editing here is the DataGridView. I have worked with that a lot in the past but seem to have forgotten many of the details. So, it'll take while to get back on track.)

@audiamus audiamus added bug Something isn't working enhancement New feature or request labels Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants