refactor: preview_auto to use enum and different option #1991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #1804. It implements an enum and adds a new table
[preview]
(should be used formax_preview_height
andshow_preview
when the new settings are implemented, although the keys should be renamed then) and theshow_preview_auto
option has been renamed as mentioned in #991 (comment)However, I am contemplating whether to change the naming:
strategy -> mode
auto -> dynamic
I believe
mode
is used in other settings and thus it might be more consistent.dynamic
as it determines the height dynamically.auto
also fits, so I really have no clue which one is better.@ellie what do you think?
Checks