fix(dotfiles): unquote aliases before quoting

[ellie]

We want to quote all aliases when setting config. Aliases in the store may be quoted, but may also be unquoted.

First normalise to unquoted, then quote.

Checks

• I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
• I have checked that there are no existing pull requests for the same thing

[tessus]

May I ask what happens with aliases like these:

alias wd='echo "`whoami`@`hostname -s`:`pwd`"'
alias cdate='if [ -n "${TZ+x}" ]; then   export SAVETZ=$TZ;   export TZ=${CLIENT_TZ};   date ;   export TZ=$SAVETZ;   unset SAVETZ; else   export TZ=${CLIENT_TZ};   date;   unset TZ ; fi'
alias dt='date +"%Y-%m-%d %H:%M:%S %z"'

[ellie]

They all work without issue!

At least setting from the CLI. I'll double check importing.

[ellie]

Yep all good for imports too

[tessus]

perfect. thanks for the info. looking at the code alone, I wasn't sure how quotes in the middle of the alias are handled.

P.S.: I had the chance to lookup string manipulation in Rust and I get the code now.