Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gov): revert duplicate amino path #51

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

tbruyelle
Copy link
Collaborator

Revert PR #44 because it can cause consensus breaking when the network is a mix of versions 1.0.3 and <1.0.3.
Also the legacy amino path are more compliants with existing clients configuration.

Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

Revert PR #44 because it can cause consensus breaking when the network
is a mix of versions 1.0.3 and <1.0.3.
Also the legacy amino path are more compliant with existing clients
configuration.
@tbruyelle tbruyelle force-pushed the tbruyelle/fix/revert-dup-amino-path branch from 0f731d9 to 3c98b40 Compare September 20, 2024 09:20
@tbruyelle tbruyelle merged commit 6a83682 into main Sep 20, 2024
13 checks passed
@tbruyelle tbruyelle deleted the tbruyelle/fix/revert-dup-amino-path branch September 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants