Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template #952 #959

Merged
merged 18 commits into from
Oct 2, 2024
Merged

Create template #952 #959

merged 18 commits into from
Oct 2, 2024

Conversation

Polleps
Copy link
Member

@Polleps Polleps commented Sep 2, 2024

Related Issues

closes #952, closes #968, closes #969, closes #967, closes #955, closes #894, closes #975, closes #763

Checklist

  • Add changelog entry linking to issue, describe API changes
  • Add or update tests if needed
  • Update docs if needed

@Polleps Polleps force-pushed the create-template-#952 branch 2 times, most recently from 9b9d17d to fffd590 Compare September 11, 2024 10:59
@Polleps Polleps marked this pull request as ready for review October 1, 2024 14:48
@@ -0,0 +1,20 @@
# @tomic/template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should advertise this template a bit more in our other docs, e.g. here

Copy link
Member

@joepio joepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@@ -0,0 +1,42 @@
{
"name": "sveltekit-site",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this should be a variable / use folder name

@joepio joepio merged commit b6ec2dc into develop Oct 2, 2024
1 check passed
@joepio joepio deleted the create-template-#952 branch October 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment