Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate trailing slash base URLs #895

Open
4 tasks done
joepio opened this issue Jun 17, 2024 · 1 comment
Open
4 tasks done

Migrate trailing slash base URLs #895

joepio opened this issue Jun 17, 2024 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Jun 17, 2024

In #505, we finally start parsing requested URLs as URLs instead of Strings. This will give all "home" URLs a trailing slash. E.g. https://atomicdata.dev ==> https://atomicdata.dev/.

This means that existing URLs to the main drives may not longer work.

In order to prevent users from getting issues, we should update their subjects when they switch to this newer system. I think that means we should add a function to migration.rs.

  • Update all home resources, append a trailing slash
  • Update all the values that point to home resources
  • Rebuild indexes.
  • Find a way to deal with Commits. => Ignore them, they become irrelevant

Commits

If the user has made commits to home instead of home/, then the commits no longer contain the correct Subject. Their contents need to be rewritten, which means the signatures no longer match the contents. So if someone would play back the commits, they would throw errors. A different approach is to

@joepio
Copy link
Member Author

joepio commented Jun 17, 2024

joepio added a commit that referenced this issue Jul 23, 2024
joepio added a commit that referenced this issue Jul 23, 2024
joepio added a commit that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant