Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the new JSON fields for Tantivy full-text search #336

Closed
joepio opened this issue Mar 23, 2022 · 0 comments · Fixed by #595
Closed

Consider the new JSON fields for Tantivy full-text search #336

joepio opened this issue Mar 23, 2022 · 0 comments · Fixed by #595
Assignees

Comments

@joepio
Copy link
Member

joepio commented Mar 23, 2022

Relates to #40 #210

The new 0.17 release of the Tantivy crate features JSON support.

Current situation

Currently, we have a custom way of indexing, which uses individual triples. This has some serious downsides, such as that if a document has multiple hits in various properties (e.g. hit in Title and Desription field), we cannot combine these and increase its weight.

Opportunities:

  • Search in all fields, combined
  • Remove some code (love it)
  • Include full resources (get_resource_extended), which includes members in collections, maybe?

Implementation suggestion

  • In server/search.rs, change the add_resource. Instead of iterating over all prop_vals, just index the full JSON-AD.
  • The build_schema now needs a json field.
  • When searching, boost the name, perhaps only fuzzy that field + description in default UI
joepio pushed a commit that referenced this issue Feb 21, 2023
joepio added a commit that referenced this issue Feb 21, 2023
@joepio joepio mentioned this issue Feb 21, 2023
6 tasks
joepio added a commit that referenced this issue Feb 21, 2023
joepio pushed a commit that referenced this issue Feb 21, 2023
joepio added a commit that referenced this issue Feb 21, 2023
joepio added a commit that referenced this issue Feb 21, 2023
joepio pushed a commit that referenced this issue Feb 21, 2023
joepio added a commit that referenced this issue Feb 21, 2023
joepio added a commit that referenced this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants