Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include External is ignored #317

Closed
joepio opened this issue Mar 11, 2022 · 2 comments
Closed

Include External is ignored #317

joepio opened this issue Mar 11, 2022 · 2 comments
Labels
bug Something isn't working lib rust atomic-lib (rust)

Comments

@joepio
Copy link
Member

joepio commented Mar 11, 2022

External resources are appearing in Collections with include_external set to false.

Relates to #316

Screenshot 2022-03-11 at 10 25 54

@joepio joepio added bug Something isn't working lib rust atomic-lib (rust) labels Mar 11, 2022
@joepio joepio added this to the v0.32 self-hosting milestone Mar 11, 2022
@joepio
Copy link
Member Author

joepio commented Mar 11, 2022

Seems to be an issue with Db::tpf

@joepio
Copy link
Member Author

joepio commented Mar 11, 2022

Seems like QueryFilter does not use include_external. We could solve this in at least two ways:

Create a new QueryFilter with includes_external

This leads to an increase in indexed collections (more disk space used), and will make indexing slower.

Filter afterwards

Keep the indexed collections intact. Always pass include_external=true to tpf. This leads to some runtime overhead, although iterating over subjects should not be that expensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib rust atomic-lib (rust)
Projects
None yet
Development

No branches or pull requests

1 participant