-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider a monorepo for Atomic-Data-Browser and Rust #216
Comments
I'd recommend to only use a monorepo for projects released in lockstep. I find it annoying and semantically confusing to "jump in time" between the release tags of the contained parts within a single git repo. |
In practice I'm using a lock-step release schedule / deployment. Both versions are kept in sync, so this already is something I'm dealing with. If it was a single repo, this would be easier. I'm not sure if I follow the jumping in time bit - this should not be necessary at any moment if this was a monorepo |
if you released Rust crates in even weeks and Node modules in uneven weeks, tagged rust-vX.Y.Z and node-vX.Y.Z, then at the node-vX.Y.Z tag the Rust code would be in the middle of development. E.g. https://github.com/rollup/plugins uses such interleaved release style. But yes, if all parts are released in lockstep that is not an issue. |
I just noticed how https://github.com/withastro/snowpack.git tags both module-specific releases and monorepo releases. What I mean is, even if now you expect to only need to release all in lockstep, then there's room for doing minor releases of individual modules in-between those lockstep releases - just make sure to use a branch for things that might get in the way of any release in any module. |
#216 e2e build lockfile Update pnpm version Fix install command Fix test linear tests Artifact folder Update readme docs, remove e2e_tests folder Pass front-end URL in ENV for e2e Rename task= Update playwright, fix test, fix readme Improve error handling versions / history try split action cache fix order Checkout cache order Fix build fix cache Update rust cache build artifacts build artifact path Build js install pnpm Moar cache Fix pnpm install Fix e2e test artifacts cache fix Fix raycast URL #637 Run e2e Fix init script init Fix e2e upload test Fix e2e snapshot linux
#216 e2e build lockfile Update pnpm version Fix install command Fix test linear tests Artifact folder Update readme docs, remove e2e_tests folder Pass front-end URL in ENV for e2e Rename task= Update playwright, fix test, fix readme Improve error handling versions / history try split action cache fix order Checkout cache order Fix build fix cache Update rust cache build artifacts build artifact path Build js install pnpm Moar cache Fix pnpm install Fix e2e test artifacts cache fix Fix raycast URL #637 Run e2e Fix init script init Fix e2e upload test Fix e2e snapshot linux
Only moving issues remains, but I'll do that only if the issues are needed to prevent flooding this repo with issues. |
We have:
atomic-server
, a CLI and a rust library. These are highly interdependent (or at least, cli and server depend on lib)Reasons to combine atomic-data-rust and atomic-data-typescript in a single repo:
data-browser
assets / JS bundles #185Reasons not to:
Steps:
build_server.sh
scriptThe text was updated successfully, but these errors were encountered: