-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run end-to-end tests in atomic-server CI #204
Comments
Now that I've got #185 pretty much done, I think this is more manageable. Still not sure what the best way forward is. This is how the e2e are executed in - uses: actions/setup-node@v2
with:
node-version: "14"
- uses: bahmutov/npm-install@v1
- run: npx playwright install-deps
- run: yarn test
This means we need to run Seems a bit much. Is there a simpler way, maybe? yes! There is Getting the test file itself is still a matter of copy/paste, which will |
#204 don't run node install #204 nohup, cargo install #204 cd server #204 undo sw commit #204 frozen lock file #204 use cache #204 try without release build #204 add nohup #204 fix test call #204 update atomic data browser js Less duplicate github actions Install playwright in ci #204 temp test try global install Whoops, npm i letsgo Try checkout twice ts js
* #204 add e2e tests #204 don't run node install #204 nohup, cargo install #204 cd server #204 undo sw commit #204 frozen lock file #204 use cache #204 try without release build #204 add nohup #204 fix test call #204 update atomic data browser js Less duplicate github actions Install playwright in ci #204 temp test try global install Whoops, npm i letsgo Try checkout twice ts js * try tests using npm * demofile fix * fix plox * npm i * after checkout * Move to last line... * Try debug build
Although the e2e tests are run in the
atomic-data-browser
CI, they are not being run here. This has previously led to broken docker builds before - and that harms the developer experience.I think it would be not that hard to run the e2e tests here.
Options:
Dockerize e2e tests, load docker image
Git pull e2e tests, run yarn
The text was updated successfully, but these errors were encountered: