Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run end-to-end tests in atomic-server CI #204

Closed
joepio opened this issue Nov 3, 2021 · 1 comment · Fixed by #321
Closed

Run end-to-end tests in atomic-server CI #204

joepio opened this issue Nov 3, 2021 · 1 comment · Fixed by #321

Comments

@joepio
Copy link
Member

joepio commented Nov 3, 2021

Although the e2e tests are run in the atomic-data-browser CI, they are not being run here. This has previously led to broken docker builds before - and that harms the developer experience.

I think it would be not that hard to run the e2e tests here.

Options:

Dockerize e2e tests, load docker image

  • Requires publishing yet another docker image

Git pull e2e tests, run yarn

  • Will probably be pretty slow
@joepio joepio added this to the v1.0.0 milestone Nov 10, 2021
@joepio joepio modified the milestones: v1.0.0, v0.32 self-hosting Mar 12, 2022
@joepio
Copy link
Member Author

joepio commented Mar 12, 2022

Now that I've got #185 pretty much done, I think this is more manageable.

Still not sure what the best way forward is.

This is how the e2e are executed in atomic-data-browser:

      - uses: actions/setup-node@v2
        with:
          node-version: "14"
      - uses: bahmutov/npm-install@v1
      - run: npx playwright install-deps
      - run: yarn test

This means we need to run yarn, which means a package.json, and the tests themselves of course.

Seems a bit much. Is there a simpler way, maybe?

yes! There is npx playwright test tests/todo-page.spec.ts, which for some reason seems to take ages to run on my laptop. Bu anyway, that would remove the need for a package.json.

Getting the test file itself is still a matter of copy/paste, which will

joepio added a commit that referenced this issue Mar 12, 2022
@joepio joepio mentioned this issue Mar 12, 2022
5 tasks
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
joepio added a commit that referenced this issue Mar 12, 2022
#204 don't run node install

#204 nohup, cargo install

#204 cd server

#204 undo sw commit


#204 frozen lock file

#204 use cache

#204 try without release build

#204 add nohup

#204 fix test call

#204 update atomic data browser js

Less duplicate github actions

Install playwright in ci #204

temp test

try global install

Whoops, npm i

letsgo

Try checkout twice

ts js
joepio added a commit that referenced this issue Mar 12, 2022
* #204 add e2e tests

#204 don't run node install

#204 nohup, cargo install

#204 cd server

#204 undo sw commit


#204 frozen lock file

#204 use cache

#204 try without release build

#204 add nohup

#204 fix test call

#204 update atomic data browser js

Less duplicate github actions

Install playwright in ci #204

temp test

try global install

Whoops, npm i

letsgo

Try checkout twice

ts js

* try tests using npm

* demofile fix

* fix plox

* npm i

* after checkout

* Move to last line...

* Try debug build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant