Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update / self-update binaries #158

Closed
Tracked by #237
joepio opened this issue Aug 5, 2021 · 6 comments · Fixed by #372
Closed
Tracked by #237

Auto-update / self-update binaries #158

joepio opened this issue Aug 5, 2021 · 6 comments · Fixed by #372

Comments

@joepio
Copy link
Member

joepio commented Aug 5, 2021

Ideally, atomic-server could update itself - without any CLI activity.

The self_update crate seems pretty nice.

We'll use Tauri for the desktop distro.

Issue on tauri to make this even easier: tauri-apps/tauri-action#251

@joepio joepio added this to the 2 minute setup of atomic-server milestone Aug 5, 2021
@joepio
Copy link
Member Author

joepio commented Aug 21, 2021

When should auto update be initialized? I think we should check (every 24 hours maybe) for new versions, and if one is found, signal the manager of the server somehow. Applying the update automatically might be a reasonable thing for some users, but for others it is too much of a risk. If anything goes wrong in a version update, the user will not be aware of this until some time later. In some situation, stability is far more important than running the latest version.

Maybe add an /update endpoint that requires a signed request from the default_agent? However, that would mean that if a user signs up using the /setup invite, they would not be allowed to update the server... Maybe check if the user has write rights on the base_url?

@joepio
Copy link
Member Author

joepio commented Nov 21, 2021

I'm planning on implementing this by using Tauri #215

@jonassmedegaard
Copy link

jonassmedegaard commented Nov 21, 2021

please provide a compile-time option to disable automatic updates: some distributions (including Debian) forbid non-package-management changes below /usr/bin and /usr/lib and /usr/share - and it is pretty awkward to have to install atomic-data below /var

@joepio
Copy link
Member Author

joepio commented Nov 21, 2021

Good point. The Tauri build will be a separate build from the regular server one. It will have desktop features, a GUI, and self-update. I'll keep supporting the regular atomic-server build, which will not have an automatic update.

@jonassmedegaard
Copy link

excellent!

@joepio
Copy link
Member Author

joepio commented Nov 25, 2021

Will probably be fixed by #221

Still needs a bit of work

joepio added a commit that referenced this issue Apr 5, 2022
@joepio joepio mentioned this issue Apr 5, 2022
4 tasks
joepio added a commit that referenced this issue Apr 10, 2022
joepio added a commit that referenced this issue Apr 10, 2022
joepio added a commit that referenced this issue Apr 11, 2022
joepio added a commit that referenced this issue Apr 13, 2022
joepio added a commit that referenced this issue Apr 13, 2022
joepio added a commit that referenced this issue Apr 13, 2022
@joepio joepio reopened this Apr 13, 2022
@joepio joepio closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants