Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

problem with <H*> tag conversion #293

Closed
adueck opened this issue Aug 19, 2015 · 7 comments
Closed

problem with <H*> tag conversion #293

adueck opened this issue Aug 19, 2015 · 7 comments
Labels

Comments

@adueck
Copy link

adueck commented Aug 19, 2015

A space is required after hashtags to make the conversion for <H*> tags work. Normally this is not required for markdown converters.

input:

### this works

result:

<H3>this works</H3>

input:

###this doesn't work

result:

###this doesn't work
@kevinsawicki
Copy link
Contributor

This package uses https://github.com/chjj/marked to generate the HTML so you might want to open an issue there.

Normally this is not required for markdown converters.

That is interesting, GitHub requires the space, what converters are you using that don't?

@hemraker
Copy link

Hey there
I'm experiencing the same issue. Github does not require the space.

screen shot 2015-08-20 at 22 56 30

Same file with markdown-preview:
screen shot 2015-08-20 at 22 49 02

@markuskonrad
Copy link

For me it looks like a GitHub feature. Based on Grubers original dokumentation, the whitespace is requried.

Also GitHub describes that in their markdown-basics.

@hemraker
Copy link

They certainly have a space in the example 😄

But it is not specific to Github, many markdown editors/parsers support it such as WMD (stack overflow), StackEdit and MacDown.

@adueck
Copy link
Author

adueck commented Aug 29, 2015

Thanks for the interest in this. Just for information's sake: I had been using markdown with Jekyll, and have never used the space, so it kind of threw me off at first. But yes, could very well be required with other converters.

@leipert
Copy link

leipert commented Sep 2, 2015

The CommnMark Specification also says, you should have a space, to avoid stuff like this:

# Header

I want to tell you about issue
#5, it is our priority  <-- no headline

@hemraker
Copy link

hemraker commented Sep 2, 2015

@leipert : I agree, the space is best practise but not supporting a thing that is used widely AND is supported by many converters seems like a shortcoming. If you don't get the correct preview then it is not really a preview.

I had to switch to another package because markdown preview doesn't give a correct representation of the files I'm working with.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants