Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Incorrect indentation when using flow and tree-sitter #25

Open
1 task done
IanVS opened this issue Oct 10, 2018 · 1 comment
Open
1 task done

Incorrect indentation when using flow and tree-sitter #25

IanVS opened this issue Oct 10, 2018 · 1 comment

Comments

@IanVS
Copy link

IanVS commented Oct 10, 2018

Prerequisites

Description

I originally opened this in atom/language-javascript#603. Duplicating here, since this seems to be the grammar being used.

When using the Flow Javascript grammar with tree-sitter enabled, I notice that parenthesis are not always outdented correctly, whereas they are when using Javascript. Here are some examples (taken during safe mode):

Javascript (correct)

javascript

Flow Javascript (incorrect)

flow

Steps to Reproduce

  1. Create a file with the flow pragma
  2. Verify the grammar shows as Flow Javascript
  3. Notice that indentation is wonky, as shown in the gif above.

Expected behavior: [What you expect to happen]
I expect the closing parenthesis to be on the same column as the first character of the line with the opening parenthesis.

Actual behavior: [What actually happens]
The closing parens is indented by one level, to the same position as the cursor.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom : 1.32.0-beta3
Electron: 2.0.9
Chrome : 61.0.3163.100
Node : 8.9.3
apm 2.1.2
npm 6.2.0
node 8.9.3 x64
atom 1.32.0-beta3
python 2.7.10
git 2.19.1

@IanVS
Copy link
Author

IanVS commented Oct 10, 2018

Also, I have to say, it's more than a little confusing that the language-typescript grammar is used to handle flow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant