Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Highlighting parentheses #47

Closed
k-k opened this issue Dec 4, 2014 · 1 comment · Fixed by #208
Closed

Highlighting parentheses #47

k-k opened this issue Dec 4, 2014 · 1 comment · Fixed by #208

Comments

@k-k
Copy link

k-k commented Dec 4, 2014

I tried taking a stab at adding this in the php.cson file - but didn't get far.

Things like if(true) or case($foo), or native functions in_array() - the parentheses are not wrapped in a span with a class(es), meaning we can't target them in syntax themes.

Example from the dom on an if statement checking a file_exists: source

Can this be added? I'll keep digging through the language file in the meantime.

@winstliu
Copy link
Contributor

winstliu commented Jun 9, 2017

Progress. Just need to fix/add specs and then I'll submit a PR. (Red highlighting added for emphasis)

Before After
php-before php-after

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants