This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add settings for formatting #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 18, 2019 22:04
For new formatting options
|
I see a few options here:
|
|
I like the popup. Until atom has some place a person can go to look at settings across packages, it's going to be hard to discover these settings. I also think it would be okay to have a short mention of the on-save setting in the README. |
|
I see this includes the change in #116. Any chance of getting one of these merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all the formatting settings from the LS configurable 🎉. And now that we have this additional level of configuration, I figure it's a good time to hook into the format-on-type and format-on-save providers. On-type can be disabled within ide-java, and on-save can be disabled via atom-ide-ui.
I still need to figure out how to make this a smooth transition, though, as I'm sure most projects aren't following Eclipse's default formatting rules.
Fixes #109