This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update package-word-count.md #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that the absence of an activationCommand in package.json causes activate to be triggered on load.
| @@ -50,7 +50,7 @@ style sheets your package needs to load. If not specified, style sheets in the ` | |||
| * `keymaps`: an Array of Strings identifying the order of the key mappings your package needs to load. If not specified, mappings in the `keymaps` directory are added alphabetically. | |||
| * `menus`: an Array of Strings identifying the order of the menu mappings your package needs to load. If not specified, mappings in the `menus` directory are added alphabetically. | |||
| * `snippets`: an Array of Strings identifying the order of the snippets your package needs to load. If not specified, snippets in the `snippets` directory are added alphabetically. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. If not specified, the activate method of your main class will be called when your package is loaded. | |||
There was a problem hiding this comment.
Pretty minor, but would you mind changing activate here to activate()?
There was a problem hiding this comment.
Sure, no problem.
| @@ -50,7 +50,7 @@ style sheets your package needs to load. If not specified, style sheets in the ` | |||
| * `keymaps`: an Array of Strings identifying the order of the key mappings your package needs to load. If not specified, mappings in the `keymaps` directory are added alphabetically. | |||
| * `menus`: an Array of Strings identifying the order of the menu mappings your package needs to load. If not specified, mappings in the `menus` directory are added alphabetically. | |||
| * `snippets`: an Array of Strings identifying the order of the snippets your package needs to load. If not specified, snippets in the `snippets` directory are added alphabetically. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. If not specified, the activate() method of your main class will be called when your package is loaded. | |||
There was a problem hiding this comment.
Ah, sorry, I wasn't clear enough – I meant also wrap it in backticks:
`activate()`
There was a problem hiding this comment.
No worries. At this point, do you want me to squash to clean up the commits, or does it not matter here?
| @@ -50,7 +50,7 @@ style sheets your package needs to load. If not specified, style sheets in the ` | |||
| * `keymaps`: an Array of Strings identifying the order of the key mappings your package needs to load. If not specified, mappings in the `keymaps` directory are added alphabetically. | |||
| * `menus`: an Array of Strings identifying the order of the menu mappings your package needs to load. If not specified, mappings in the `menus` directory are added alphabetically. | |||
| * `snippets`: an Array of Strings identifying the order of the snippets your package needs to load. If not specified, snippets in the `snippets` directory are added alphabetically. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. | |||
| * `activationCommands`: an Object identifying commands that trigger your package's activation. The keys are CSS selectors, the values are Arrays of Strings identifying the command. The loading of your package is delayed until one of these events is triggered within the associated scope defined by the CSS selector. If not specified, the `activate()` method of your main class will be called when your package is loaded. | |||
There was a problem hiding this comment.
Alright, one last thing – I think "main export" would work better here, because packages don't have to export a class – they just export a plain object with a set of optional methods.
|
Thanks for adding this! 🚀 |
This was referenced May 27, 2020
This was referenced Sep 24, 2020
Open
This was referenced Jan 12, 2022
This was referenced Dec 16, 2023
This was referenced Dec 23, 2023
This was referenced Dec 31, 2023
This was referenced Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that the absence of an activationCommand in package.json causes activate to be triggered on load.