Move API docs functionality from search.js to api-docs.js

atom · Jul 15, 2019 · b3e6add · b3e6add · ellis9983 · Feb 15, 2020
1 parent ccef5c1
commit b3e6add
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 25 deletions.
diff --git a/assets/javascripts/api-docs.js b/assets/javascripts/api-docs.js
@@ -1,19 +1,33 @@
 (function() {
-  $(document).on("click", ".js-api-name", function(e) {
-    e.preventDefault();
-    toggleApiEntry($(this).attr("href"));
-    return false;
-  });
+  if (isApiDocsPage()) {
+    $(document).on("click", ".js-api-name", function(e) {
+      e.preventDefault();
+      toggleApiEntry($(this).attr("href"));
+      return false;
+    });
 
-  $(document).ready(function() {
-    if (window.location.hash) {
-      toggleApiEntry(window.location.hash);
-    }
-  });
+    $(document).ready(function() {
+      if (window.location.hash) {
+        toggleApiEntry(window.location.hash);
+      }
 
-  $(window).on("hashchange", function() {
-    toggleApiEntry(window.location.hash);
-  });
+      $("#documents-search-versions").change(function() {
+        const components = window.location.pathname.split("/");
+        if (!components[components.length - 1]) {
+          // Pop trailing slash off
+          components.pop();
+        }
+        const page = components.pop();
+        const version = this.value;
+        const { hash } = window.location;
+        window.location.replace(`/api/v${version}/${page}${hash}`);
+      });
+    });
+
+    $(window).on("hashchange", function() {
+      toggleApiEntry(window.location.hash);
+    });
+  }
 
   function toggleApiEntry(apiEntryId) {
     const entry = $(apiEntryId);
@@ -29,4 +43,8 @@
       window.history.replaceState("", "", apiEntryId); // update url hash w/o adding history
     }
   }
+
+  function isApiDocsPage() {
+    return window.location.pathname.startsWith("/api/");
+  }
 })();
diff --git a/assets/javascripts/search.js b/assets/javascripts/search.js
@@ -27,14 +27,6 @@ $(document).ready(function() {
     if (isSearchPage()) {
       params.set("v", version);
       window.history.pushState(null, null, "?" + params.toString());
-    } else if (isApiDocsPage()) {
-      const components = window.location.pathname.split('/')
-      if (!components[components.length - 1]) {
-        // Pop trailing slash off
-        components.pop()
-      }
-      const page = components.pop()
-      window.location.replace(`/api/v${version}/${page}`)
     }
 
     search.reindex(version, "/search/v" + version + ".json");
@@ -224,7 +216,3 @@ class LunrSearch {
 function isSearchPage() {
   return window.location.pathname.match(/\/search(?:\/|$)/);
 }
-
-function isApiDocsPage() {
-  return window.location.pathname.startsWith('/api/')
-}