Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Remove parenthesis from autocompletion of values #40

Open
dcalhoun opened this issue Jan 18, 2016 · 3 comments
Open

Remove parenthesis from autocompletion of values #40

dcalhoun opened this issue Jan 18, 2016 · 3 comments

Comments

@dcalhoun
Copy link

Currently, autocomplete includes parenthesis (and closing semicolons) to values that require parenthesis (e.g. – translate()). In theory this sounds nice, but in practice it just requires a user to move their cursor backwards into the parenthesis.

Autocompleting the "translate" value is an example:

.some-selector {
  transform: translate();[CURSOR]
}

Given that placing the cursor within the parenthesis is not within the scope of autocomplete and should be handled by a snippet, I propose it's better to not autocomplete values like this with parenthesis and semicolons.

.some-selector {
  transform: translate[CURSOR]
}

There are plenty of values that fall into this, translate is just one example.

@dcalhoun
Copy link
Author

dcalhoun commented Feb 1, 2016

I looked into contributing this change, but it appears this package relies on an Adobe Brackets config file. So, it seems this change would require abandoning the approach, correct?

Is there a desire to move away from the Adobe Brackets dependency or is it a better approach to lobby this change within Adobe Brackets? If the latter, how likely is it that the Adobe Brackets team would make this change?

Side note — this line about "running this to update static list of properties" is very ambiguous. Am I able to "run this" from the command line or is does the package merely run the file itself on activation? Any clarification would helpful. Thanks!

@benogle
Copy link
Contributor

benogle commented Feb 1, 2016

I think we could keep the current approach, but add a little more intelligence to update.coffee. There are probably more than just this one that should be converted into a snippet. Autocomplete can return snippets, so it would be a matter of post-processing in the update.coffee, storing them a little different in the resulting completions.json, and reading them a little differently in the provider. We would definitely check out a PR using this approach. Thanks for digging in!

@mikedejong
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants