Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Refactoring packages #1126

Closed
18 tasks done
kevinsawicki opened this issue Nov 19, 2013 · 1 comment
Closed
18 tasks done

Refactoring packages #1126

kevinsawicki opened this issue Nov 19, 2013 · 1 comment

Comments

@kevinsawicki
Copy link
Contributor

List of things that should be done to clean up each package

Remove use of window globals and use them from atom global instead

  • window.syntax ➡️ atom.syntax
  • window.config ➡️ atom.config
  • window.pasteboard ➡️ atom.pasteboard
  • window.keymap ➡️ atom.keymap
  • window.project ➡️ atom.project
  • window.rootView ➡️ atom.rootView

Remove use of package manager methods on atom, use them via atom.packages instead

  • atom.activatePackage ➡️ atom.packages.activatePackage

Remove use of deserializer helpers on window

  • registerDeserializer ➡️ atom.deserializers.add

Remove use of emissary Emitter shims

  • one ➡️ once
  • trigger ➡️ emit
  • subscriptionCount ➡️ getSubscriptionCount

Remove use of the following fs methods

  • exists ➡️ existsSync
  • makeTree ➡️ makeTreeSync
  • move ➡️ moveSync
  • read ➡️ readFileSync
  • remove ➡️ removeSync
  • write ➡️ writeFile
  • writeSync ➡️ writeFileSync
@lock
Copy link

lock bot commented Jan 27, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant