-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering Virtualization Support #68
Comments
We were talking about this the other day. Right now it is not on our roadmap - but it would be cool to see if we could get this working |
I'm using react-infinite wrapped with react-sortable-hoc. That's can be done with react-beautiful-dnd ? |
Not at this stage - we have not built for it. It would probably require #86 before we could tackle this one |
This will need to be considered as part of the solution for #86 |
We're using this library and it works flawlessly! Is there any way to promote this? |
Right now we have a few other core features that we are looking to build out. Mobile and auto scrolling. Once those are completed we can re evaluate 👍 |
@alexreardon Thanks! that would be great! Unfortunately we do need this right now, so I was thinking of doing a virtualization by hand (removing the elements that are outside the viewport), do you think I would encounter any issues by removing |
I am not sure @OriR as I have not looked into it yet. You will probably run in to trouble though. The way we do things today is that before a drag officially starts we grab all the dimensions of everything and then proceed from there. So if something is not there - or if it does not have its true dimensions then things will go wrong. This will be thought of as apart of #86 |
Thanks! I also think this should be taken into account when doing #27 since virtualization relies heavily on scrolling. |
I was hoping to do this with #86 but it will need to wait until after we upgrade to react 16 #192. The current approach of applying styles to the element in place does not play well with virtual lists which have fairly opinionated positioning and layering. By moving to a portal we will be able to play well with virtual lists. I am doing a lot of the pre-work for virtual lists in #86 but virtual lists will not be totally supported. You might be able to get it working if you look at the technique (hack) in #192 which demonstrates how you can set up your own portal. |
@alexreardon I see #86 is closed and that #192 is marked with "priority: low" while this is "priority: medium". |
@alexreardon Autoscroll day is celebrated today! |
I'm using both |
Just to confirm, this is now on the roadmap, right? |
Changes we need need to make:
|
We are running react-beautiful-dnd on our production app and, for the most part, it's great! However, there are cases where our users have ~1000+ droppables, and you can really feel the performance / lag. @alexreardon, you mentioned above that you were hopeful to work on this in the coming months – are you able to confirm if this is still the case? 🙏 |
I'm using both |
@pureZjr can you share an example? |
@pureZjr That's how it is designed the library for now. You can remove everything else other than the current dragged item. Check the changelogs of the 10.0 v when it came out |
any updates about using React Virtualized with React Beautiful DnD ? |
Any updates on this? |
It looks like it'll be in the 12.0 release. https://twitter.com/alexandereardon/status/1138960614447915014 |
It will ship in 12.0. See #1225 |
Thanks a lot @alexreardon for your work ;) |
#1225 contains the alpha releases which you can use to try this out |
@alexreardon is it working great under stable version now ? |
Soon! I am aiming for next week |
@alexreardon here is a croissant with the hope to see the release soon : 🥐 |
@alexreardon Thank you so much for the release!!! You are amazing! |
This has been released in 12.0 :D |
Hello, is there any plan for release new version of https://www.npmjs.com/package/@types/react-beautiful-dnd/v/11.0.3 for this virtualized list feature? |
Feature request
We are evaluating D&D libraries and we found that some, like React Sortable have virtualization features or, work with libraries such as React Virtualized.
Is rendering virtualization support part of the current plans?
The text was updated successfully, but these errors were encountered: