-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with new jsx automatic transform #349
Comments
You will need to use Also, if you don't have the following exports, then you will need them:
Source: emotion-js/emotion#1970 |
hi @karlhorky - interestingly we don't actually use a custom jsx pragma - so the theory is we won't have to do much to get it working. still need to test soon though! 😄 |
Ah nice, good to hear! Best of luck! |
Wonder if these things will still be needed for TypeScript support (the |
Hi, what are we talking about? 🙂 When using Babel it doesn't really matter what your setting is for JSX because TSC isn't used to compiled your code. |
For sure - I'm thinking of other situations such as when TS tries to figure out the JSX transform and comes across the unknown |
hmm yeah that's a good point - we could definitely have that problem 😅 will take inspiration from emotion for their solution later when it comes up. |
Currently unsure if we need to do anything to make it work.
The text was updated successfully, but these errors were encountered: