Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear documentation for migrating from styled components with a theme #1190

Open
jeremylynch opened this issue Apr 10, 2022 · 1 comment
Labels
documentation 📚 Improvements or additions to documentation triage 🩺

Comments

@jeremylynch
Copy link

Note a common feature used in Styled components is theming. I note #184 which introduces theming to this library. However, there is nothing in the documentation for this. Are we able to add createThemeProvider to the documentation?

@pancaspe87
Copy link
Collaborator

Hi @jeremylynch,

Thanks for reporting the missing info.

We have elected to not support theming (styled-components: Advanced Usage) in Compiled as the implementation complexity is high and the same affect can be achieved with CSS variables.

Documentation doesn't include some of the latest features and decisions; we'll try to update it asap.

@pancaspe87 pancaspe87 added documentation 📚 Improvements or additions to documentation triage 🩺 labels Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation triage 🩺
Projects
None yet
Development

No branches or pull requests

2 participants