-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal executor should (re)load whole modal incl. buttons #1928
Comments
This is complicated, as Fomantic-UI requires the modal title/buttons to be not wrapped in any div. |
Could you explain? The modal header is actually expected to be wrapped in a "header" and the buttons are expected to be wrapped in an "actions" div... So where does FUI not expect them to be wrapped? |
(AFAIR, not on desktop ATM to provide source code references) FUI modal expects header/button wrapper divs to be present immediatelly after the main modal div. This limitation is not compatible with our atk4/ui reload impl, as we cannot reload inner html without the wrapping div (outer html) reload. |
currently only modal inner content/view is r(e)loaded causing uncessary html/js generated like:
no modal content should be generated before displayed (when inner content/view is loaded via API) and once AJAX for (re)load is fired, whole content should be rendered/downloaded
this will improve performance when main page has a lot of modal executors and also allow greater executor buttons customizations per (re)loaded content/records
filter popup generates a lot code as well, maybe move it to AJAX completely as well
The text was updated successfully, but these errors were encountered: