Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix block move after last block #2089

Merged
merged 4 commits into from
Mar 22, 2022
Merged

fix block move after last block #2089

merged 4 commits into from
Mar 22, 2022

Conversation

sid597
Copy link
Collaborator

@sid597 sid597 commented Mar 21, 2022

No description provided.

@vercel
Copy link

vercel bot commented Mar 21, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/GQ5zPZq1aTjjSzhnFmTReCFf9ygQ
✅ Preview: https://athens-git-fork-sid597-fix-block-move-athens-research.vercel.app

@sid597
Copy link
Collaborator Author

sid597 commented Mar 21, 2022 •
edited
Loading

Tests to perform

Make the selected block

  • as first block
  • as the last block
  • as the first child of a block
  • as the sibing of the parent

I think other drag and drop result in one of the above cases

@neotyk
Copy link
Collaborator

neotyk commented Mar 21, 2022

@sid597 can we get some tests with it?

@sid597
Copy link
Collaborator Author

sid597 commented Mar 21, 2022

@sid597 can we get some tests with it?

yes

neotyk
neotyk approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@neotyk neotyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neotyk neotyk merged commit 0fbf4ef into athensresearch:main Mar 22, 2022
@neotyk neotyk deleted the fix-block-move branch March 22, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neotyk neotyk neotyk approved these changes

@tangjeff0 tangjeff0 Awaiting requested review from tangjeff0

@filipesilva filipesilva Awaiting requested review from filipesilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sid597 @neotyk