-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure in Matlab / Python comparison tests #305
Comments
A1 is a coefficient for amplitude detuning. It is derived from the harmonic analysis of the turn-by-turn motion of the beam at several amplitudes and a polynomial fit of this data. |
The numbers are completely different: 3005.9 and 95517.6. If it's fine that the numbers are completely different just confirm that and I will remove that check. |
I noticed this happening after merging #267. I suspect a problem with the new python version, but did not look at it yet… |
Ok , yes this is big and is most likely a problem, let's leave it open. I ll try to check when I have some time. Most likely not before next week |
Ok so the issue is the periodicity, in fact there is a factor 32 between the matlab and the python. This is an issue in matlab rather than python I would say, which brings back #169 on the table (same issue different time...), for me this parameter is bringing a lot of issues and very little added value...the only place where I can see it fit is in ringparam/atsummary where it could simply be given as input argument rather than being a lattice property. |
The bug is indeed in Matlab, corrected in #314 |
A significant difference in A1 when using fastring, not that I know what A1 is specfically.
cc @MJGaughran
The text was updated successfully, but these errors were encountered: