Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #34

Open
atc0005 opened this issue Aug 20, 2020 · 0 comments
Open

Add tests #34

atc0005 opened this issue Aug 20, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request tests
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Aug 20, 2020

Lots of tests. Or, just a few tests, but tests we should have.

In particular, XPath queries against a sample configuration file reflecting what I've found in each of the three LOCKSS networks I've tested this tool against.

In the example files, I should hard-code some IPs that should not be returned, and some that should. I should (for the sake of recognition), re-use the same sets across all three files as appropriate. This way, a "should never match" IP can be recognized by sight in the tests if needed.

There is room for tests across the board however, so at this point nearly anything would be useful.

@atc0005 atc0005 added enhancement New feature or request tests labels Aug 20, 2020
@atc0005 atc0005 added this to the Future milestone Aug 20, 2020
@atc0005 atc0005 self-assigned this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

No branches or pull requests

1 participant