-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nexti18nSetup for OG tags error #3111
Changes from 11 commits
f1a57a0
69c43f2
960d694
10a2516
6f8e0fb
e70371e
ec0864a
679f6bc
85485e9
66debb3
96d4691
863fdc7
fb522bd
805dbf7
a5506e9
9b97fc0
5d99ef2
23c3f29
c404023
d764b8e
b966aff
6a04253
407a96a
db5a459
07cbf4b
46bc14b
8518729
23161d7
94560ff
56dabcc
f2cd8e8
a11b129
56cdf32
ea9048f
ef89be9
01fcb80
3bf1b18
24233a8
e879cd3
451f48d
671b0ba
3bbbe4f
a3d0dbe
81fce4f
ff6c0b4
5d43180
8b88156
428bf11
420ec89
6bc1848
1f20cba
a1e0906
62c1c2d
bf1b1ee
cff22dd
d2740c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,3 +57,23 @@ export function TableHeader(props: React.HTMLProps<HTMLTableCellElement>) { | |
/> | ||
); | ||
} | ||
|
||
/** | ||
* Renders the body of a table. | ||
* | ||
* @param props - The HTML props for the `<tbody>` element. | ||
* @returns The rendered `<tbody>` element. | ||
*/ | ||
export function TableBody(props: React.HTMLProps<HTMLTableSectionElement>) { | ||
return <tbody {...props} className={`${props.className || ''}`} />; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lint error. Fix the spacing. |
||
} | ||
|
||
/** | ||
* Renders the body of a table. | ||
* | ||
* @param props - The HTML props for the `<tbody>` element. | ||
* @returns The rendered `<tbody>` element. | ||
*/ | ||
export function Thead(props: React.HTMLProps<HTMLTableSectionElement>) { | ||
return <thead {...props} className={`${props.className || ''}`} />; | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -27,7 +27,7 @@ export default function Header() { | |||||
href='https://github.com/asyncapi?type=source#-contribute-to-asyncapi' | ||||||
target='_blank' | ||||||
/> | ||||||
<GithubButton className='lg:mt-0' /> | ||||||
<GithubButton text= 'View on Github' className='lg:mt-0' /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Fix the spacing. |
||||||
<SlackButton className='lg:mt-0' /> | ||||||
</div> | ||||||
</div> | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -43,7 +43,7 @@ export default function FeaturedBlogPost({ post, className = '' }: FeaturedBlogP | |||||||||||||||||||||||||||
return ( | ||||||||||||||||||||||||||||
<div className={`rounded-lg ${className}`}> | ||||||||||||||||||||||||||||
<article className='h-full rounded-lg'> | ||||||||||||||||||||||||||||
<Link href={post.slug}> | ||||||||||||||||||||||||||||
<div > | ||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Link was causing the hydration to fail (see screenshot) The reason behind the hydration error was that we are nesting a The first
|
<Link href={post.slug}> |
The second (nested) <Link>
Tag:
website/components/newsroom/FeaturedBlogPost.tsx
Lines 69 to 78 in 6159306
<Link href={post.slug}> | |
<span className='block' data-testid='FeaturedBlog-title'> | |
<Heading level={HeadingLevel.h3} typeStyle={HeadingTypeStyle.smSemibold} className='mt-2'> | |
{post.title} | |
</Heading> | |
<Paragraph typeStyle={ParagraphTypeStyle.sm} className='mt-3'> | |
<TextTruncate element='span' line={2} text={post.excerpt} /> | |
</Paragraph> | |
</span> | |
</Link> |
Both of these links has the same target (i.e. post.slug). So removing the outer Ling tag should not have any side effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div > | |
<div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,7 +165,7 @@ servers: | |
The API client must request an authentication "token" via the following REST API endpoint "GetWebSocketsToken" to connect to WebSockets Private endpoints. For more details, read https://support.kraken.com/hc/en-us/articles/360034437672-How-to-retrieve-a-WebSocket-authentication-token-Example-code-in-Python-3 | ||
|
||
The resulting token must be provided in the "token" field of any new private WebSocket feed subscription: | ||
``` | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this Codeblock is removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please Go to the production url https://www.asyncapi.com/blog/websocket-part2
After Fixing the i18n configuration, the most part of the site started to render on the server. So any inconsistency in the markdown can be caught during the build. When we kept the codeblocks, the following error was occuring during build There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But we show that code as part of codeblock. Don't we have any solution for it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sambhav has pushed solution in this commit. PTAL. Thanks. |
||
\{ | ||
"event": "subscribe", | ||
"subscription": | ||
|
@@ -174,7 +174,7 @@ servers: | |
"token": "WW91ciBhdXRoZW50aWNhdGlvbiB0b2tlbiBnb2VzIGhlcmUu" | ||
} | ||
} | ||
``` | ||
|
||
``` | ||
|
||
### Endpoints aka Channels | ||
|
@@ -473,7 +473,7 @@ servers: | |
The API client must request an authentication "token" via the following REST API endpoint "GetWebSocketsToken" to connect to WebSockets Private endpoints. For more details read https://support.kraken.com/hc/en-us/articles/360034437672-How-to-retrieve-a-WebSocket-authentication-token-Example-code-in-Python-3 | ||
|
||
The resulting token must be provided in the "token" field of any new private WebSocket feed subscription: | ||
``` | ||
|
||
\{ | ||
"event": "subscribe", | ||
"subscription": | ||
|
@@ -482,7 +482,7 @@ servers: | |
"token": "WW91ciBhdXRoZW50aWNhdGlvbiB0b2tlbiBnb2VzIGhlcmUu" | ||
} | ||
} | ||
``` | ||
|
||
|
||
channels: | ||
/: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,7 +123,7 @@ Map of filesystem paths to target AsyncAPI documents. | |
|
||
Field Pattern | Type | Description | ||
---|:---:|--- | ||
{contextName} | `string` | An optional string value representing filesystem path to the target AsyncAPI document. | ||
\{contextName\} | `string` | An optional string value representing filesystem path to the target AsyncAPI document. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cli docs are maintained in cli repo only so we need to make changes there |
||
### <a name="minimalEmptyContextFile"></a>Minimal Empty Context File | ||
Raw JSON: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
--- | ||
title: 'Metrics Collection' | ||
weight: 20 | ||
--- | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this part is handled in the workflow of cli to update the docs in the website. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was creating an error for us in rendering docs |
||
# Metrics collection guideline | ||
|
||
AsyncAPI **anonymously** tracks command executions to improve the specification and tools, ensuring no sensitive data reaches our servers. It aids in comprehending how AsyncAPI tools are used and adopted, facilitating ongoing improvements to our specifications and tools. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ export async clientAuth({ parsedAsyncAPI, serverName }) { | |
} | ||
``` | ||
|
||
Glee will utilize the `token` for server authentication, employing it in the header with the format: Authorization: Bearer {token}. | ||
Glee will utilize the `token` for server authentication, employing it in the header with the format: Authorization: Bearer \{token\}. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please be clear that glee docs are maintained from website or not. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. glee docs are maintained in glee repo |
||
|
||
### Server side | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,7 @@ These scripts refer to the different stages of developing an application. | |
|
||
#### Create `asyncapi.yaml` file and other required directories | ||
|
||
Create a yaml file that supports capable of receiving a "hello {name}" message with the protocol as `ws` and the channel name as `hello` the hello API will subscribe to. The operationId property is `onHello` that's the name of function and the payload property is type string publishing to that channel. | ||
Create a yaml file that supports capable of receiving a "hello \{name\}" message with the protocol as `ws` and the channel name as `hello` the hello API will subscribe to. The operationId property is `onHello` that's the name of function and the payload property is type string publishing to that channel. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make these changes in the docs of the cli repo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok |
||
|
||
```yaml | ||
asyncapi: 3.0.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import type { MDXComponents } from 'mdx/types'; | ||
|
||
import { mdxComponents } from '@/components/MDX/MDX'; | ||
|
||
// This file allows you to provide custom React components | ||
// to be used in MDX files. You can import and use any | ||
// React component you want, including inline styles, | ||
// components from other libraries, and more. | ||
|
||
export function useMDXComponents(components: MDXComponents): MDXComponents { | ||
return { | ||
// Allows customizing built-in components, e.g. to add styling. | ||
...mdxComponents, | ||
...components | ||
}; | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
module.exports = { | ||
i18n: { | ||
locales: ['en', 'de'], | ||
defaultLocale : 'en', | ||
namespaces: ['landing-page', 'common', 'tools'], | ||
defaultNamespace: 'landing-page', | ||
react: { useSuspense: false },// this line | ||
}, | ||
|
||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,11 +22,14 @@ const nextConfig = { | |
} | ||
|
||
return config; | ||
} | ||
}, | ||
'trailingSlash': true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a comment above on why this is added in next config. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sambhavgupta0705 Can we please remove the this |
||
|
||
}; | ||
|
||
const mdxConfig = withMDX({ | ||
extension: /\.mdx?$/, | ||
providerImportSource: "@mdx-js/react", | ||
options: { | ||
remarkPlugins: [frontmatter, gemoji, headingId, slug, images, a11yEmoji, remarkGfm], | ||
rehypePlugins: [] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
a
, we should useLink
tag to navigate internal pages of website.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a new issue for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatnema .