-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ambassador program page #1123
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
I leave here some suggestions 🙂
|
emoji: '📚', | ||
title: 'Education', | ||
details: | ||
'Ambassadors are provided with a budget plan that they use for personal development tools, like books, courses, and other learning methods.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you said privately that there would be a budget for ambassadors' education 😆. Guess i heard you wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well maybe in future, once we have some payed education 😄 but for now it is not mentioned in official documentation
Become an AsycnAPI Ambassador | ||
</Heading> | ||
<Heading typeStyle="body-sm"> | ||
The AsyncAPI Ambassador is now open for nominations! If you’re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what nominations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning folks can nominate themselves or others to become an ambassador now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then please make it sound clearer as I was first thinking about some community nominations automatically
<Button | ||
className="block md:inline-block focus:outline-none mt-10 text-center" | ||
text="Apply to become one" | ||
href="https://github.com/orgs/asyncapi/discussions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg can you point me to the correct link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget about changing link
</div> | ||
<div className="w-[50%] lg:block hidden"> | ||
<img | ||
src="/img/homepage/ambassador-cover.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you make sure this image comes from free source so no license applies to this picture, maybe we should display some "thank you"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it from pixels, and i believe all i have to do is give some credit to the creator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, then make sure we do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant design and implementation @AceTheCreator. Kudos to you. Here are certain changes I have in mind and want your opinion:
I think we can improve this card design in terms of UI. Because I see, we are implementing it like a primitive card on a webpage. Probably we can use some shadows, logos for sharing and a bit of more styling to make cards more attractive.
Makes sense @akshatnema but I don't feel it's necessary for the first iteration. wyt @derberg |
you're right about this, and I feel it already falls under this PR #1122
I'll get rid of it |
@Barbanio i added a profile section for each ambassador as requested |
@AceTheCreator, this looks great! 👏👏👏 |
Co-authored-by: Lukasz Gornicki <[email protected]> Co-authored-by: akshatnema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
https://deploy-preview-1123--asyncapi-website.netlify.app/community/ambassadors LGTM ❤️ what is the status of updating the Ambassadors file from https://github.com/asyncapi/community/blob/master/AMBASSADORS_MEMBERS.json? |
Looks good to me too 🙂 |
@derberg I'm gonna open a PR updating that and according to the discussion the ambassador country flag is gonna be optional, so ambassadors can decide to put it up or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you for all your hard work! This looks amazing ✨
@AceTheCreator sounds good, just remember that in asyncapi/community#553 you did not include flag idea. Just making sure you know, that is it. Not a killer feature for me 😀 |
Oh! let me ask the current ambassadors 😄 |
@AceTheCreator oh man, slow down, look at commits and amount of changed files 😅 |
This PR is ready IMHO cc @derberg @alequetzalli @akshatnema |
@AceTheCreator why there are changes in |
I think I accepted the incoming changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨✨✨✨
/rtm |
The ambassador's page implementation
Link to preview https://deploy-preview-1123--asyncapi-website.netlify.app/community/ambassadors