Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ambassador program page #1123

Merged
merged 67 commits into from
Jan 20, 2023
Merged

feat: ambassador program page #1123

merged 67 commits into from
Jan 20, 2023

Conversation

AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Nov 21, 2022

The ambassador's page implementation

Link to preview https://deploy-preview-1123--asyncapi-website.netlify.app/community/ambassadors

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c72634f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63c872631b9acd00091eede9
😎 Deploy Preview https://deploy-preview-1123--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Barbanio
Copy link
Contributor

I leave here some suggestions 🙂

  • Regarding the topic of linking the FAQ document to the page, maybe we could do it with the two tabs that say become an ambassador ("Apply to become one" and "Become an Ambassador now").

  • On the other hand, I think it would be great to add the merits of each ambassador, the articles they have written, the talks, programs they have led...

  • And I think the program doesn't contain this benefit:

Captura de Pantalla 2022-11-22 a las 10 27 26

emoji: '📚',
title: 'Education',
details:
'Ambassadors are provided with a budget plan that they use for personal development tools, like books, courses, and other learning methods.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not true 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you said privately that there would be a budget for ambassadors' education 😆. Guess i heard you wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well maybe in future, once we have some payed education 😄 but for now it is not mentioned in official documentation

Become an AsycnAPI Ambassador
</Heading>
<Heading typeStyle="body-sm">
The AsyncAPI Ambassador is now open for nominations! If you’re
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what nominations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning folks can nominate themselves or others to become an ambassador now :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then please make it sound clearer as I was first thinking about some community nominations automatically

<Button
className="block md:inline-block focus:outline-none mt-10 text-center"
text="Apply to become one"
href="https://github.com/orgs/asyncapi/discussions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg can you point me to the correct link?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget about changing link

</div>
<div className="w-[50%] lg:block hidden">
<img
src="/img/homepage/ambassador-cover.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you make sure this image comes from free source so no license applies to this picture, maybe we should display some "thank you"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it from pixels, and i believe all i have to do is give some credit to the creator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, then make sure we do

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant design and implementation @AceTheCreator. Kudos to you. Here are certain changes I have in mind and want your opinion:

image

I think we can improve this card design in terms of UI. Because I see, we are implementing it like a primitive card on a webpage. Probably we can use some shadows, logos for sharing and a bit of more styling to make cards more attractive.

@AceTheCreator
Copy link
Member Author

I think we can improve this card design in terms of UI. Because I see, we are implementing it like a primitive card on a webpage. Probably we can use some shadows, logos for sharing and a bit more styling to make cards more attractive.

Makes sense @akshatnema but I don't feel it's necessary for the first iteration. wyt @derberg

@AceTheCreator
Copy link
Member Author

AceTheCreator commented Dec 1, 2022

I leave here some suggestions 🙂

  • Regarding the topic of linking the FAQ document to the page, maybe we could do it with the two tabs that say become an ambassador ("Apply to become one" and "Become an Ambassador now").
  • On the other hand, I think it would be great to add the merits of each ambassador, the articles they have written, the talks, programs they have led...

you're right about this, and I feel it already falls under this PR #1122

  • And I think the program doesn't contain this benefit:

Captura de Pantalla 2022-11-22 a las 10 27 26

I'll get rid of it

@AceTheCreator
Copy link
Member Author

@Barbanio i added a profile section for each ambassador as requested

@Barbanio
Copy link
Contributor

Barbanio commented Dec 6, 2022

@Barbanio i added a profile section for each ambassador as requested

@AceTheCreator, this looks great! 👏👏👏

@AceTheCreator
Copy link
Member Author

I updated this PR with suggested changes. Any other suggestions?

cc @alequetzalli @derberg @Barbanio

@derberg
Copy link
Member

derberg commented Dec 15, 2022

@Barbanio
Copy link
Contributor

Looks good to me too 🙂

@AceTheCreator
Copy link
Member Author

https://deploy-preview-1123--asyncapi-website.netlify.app/community/ambassadors LGTM ❤️

what is the status of updating the Ambassadors file from https://github.com/asyncapi/community/blob/master/AMBASSADORS_MEMBERS.json?

@derberg I'm gonna open a PR updating that and according to the discussion the ambassador country flag is gonna be optional, so ambassadors can decide to put it up or not

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you for all your hard work! This looks amazing ✨

Copy link
Member

derberg commented Dec 21, 2022

@AceTheCreator sounds good, just remember that in asyncapi/community#553 you did not include flag idea. Just making sure you know, that is it. Not a killer feature for me 😀

@AceTheCreator
Copy link
Member Author

@AceTheCreator sounds good, just remember that in asyncapi/community#553 you did not include flag idea. Just making sure you know, that is it. Not a killer feature for me 😀

Oh! let me ask the current ambassadors 😄

@derberg
Copy link
Member

derberg commented Dec 21, 2022

@AceTheCreator oh man, slow down, look at commits and amount of changed files 😅

@AceTheCreator
Copy link
Member Author

This PR is ready IMHO cc @derberg @alequetzalli @akshatnema

@akshatnema
Copy link
Member

@AceTheCreator why there are changes in tools.json and tools-automated.json file? Have you accepted Current Changes instead of Incoming Changes in merge conflicts?

@AceTheCreator
Copy link
Member Author

AceTheCreator commented Jan 18, 2023

@AceTheCreator why there are changes in tools.json and tools-automated.json file? Have you accepted Current Changes instead of Incoming Changes in merge conflicts?

I think I accepted the incoming changes.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨✨

@derberg derberg requested a review from akshatnema January 20, 2023 10:03
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit bce0da2 into asyncapi:community Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.