-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add Docker Compose Support and Update Documentation #3542
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Shall i wait for maintainers to assign it to me or should i make a pr without getting assigned |
@abhayymishraa i dont see a need for docker-compose . The Dockerfile already is pretty basic - just runs the nextjs app no db connections as well. |
Hey @SahilDahekar , I get your point, but here’s why I think adding a docker-compose.yml could really help:
What do you think? 😊 |
All these features are good but doesnt really make a difference at this point . Maybe other issues can have more impact . Think of it . Btw , issues are not assigned here you can start contributing and make a PR . But just verify with a maintainer if they need this change . |
Bro think it this way, if this project have a Dockerfile even the next js project are so easy to set up still we have a Dockerfile let's say a developer who is using Dockerfile for their development process they have to make docker build and run every time to show changes .I think its heptic . |
Hi, I’ve raised PR #3554 to address this issue by adding a Docker Compose file. Please let me know if there are additional improvements or changes needed. Looking forward to your feedback! |
@Pratikkale26 i was working on it . you've raised a pr without assignment !! Please read Contributing Guidelines |
I don't see a need for a docker-compose file as there is no separate backend/db that we can combine into a docker-compose. Also, there's a Dockerfile that does the work. With vscode .devcontainers or WSL2, I don't see a need for Docker volumes as well. |
Why do we need this improvement?
The project currently includes a Dockerfile for containerizing the application, but lacks a docker-compose.yml. Docker Compose would greatly enhance the usability of the project by providing an easy, consistent way to manage multi-container setups.
Additionally, by attaching volumes, developers can benefit from real-time code synchronization between their local file system and the running container. This eliminates the need to rebuild the container every time code changes, significantly improving development speed and reducing friction.
How will this change help?
Simplify Setup:
Users can spin up the entire environment with a single docker-compose up command.
Volumes will enable real-time code updates without the need to rebuild the container, creating a smoother development process.
Ideal for developers who want to work on the project without worrying about container lifecycle management.
By lowering the barrier to entry for new contributors through simplified setup and better tooling, the project can attract a wider developer base.
Documentation updates will ensure contributors have clear instructions for using Docker Compose, making the project more accessible to all.
Screenshots
No response
How could it be implemented/designed?
By creating a docker-compose.yml in the project and attach it with the current Dockerfile and then implement the docker-compose.yml
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: