-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated index.tsx and fixed the gap problem at the last text at the bottom of the landing page #3491
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
npm warn config production Use WalkthroughThe pull request introduces a modification to the testimonial text for Eric Horesnyi in the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)pages/[lang]/index.tsx (2)
The PR description mentions fixing a gap between description text and author details, but the only change is updating testimonial text. Could you please:
The testimonial text update itself looks good, but it's unclear if this alone resolves the reported layout problem. Let's check the git history for any related layout fixes:
While the updated testimonial text is well-written and aligns with AsyncAPI's mission, please ensure:
Let's check for responsive design handling: Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3491 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3491--asyncapi-website.netlify.app/ |
I would again have to close this PR. @BalrajDhakad Kindly restrain from opening such PRs without prior issue triage from one of the maintainers. |
Okay, thanks for making it clear. |
Screenshots
Before Fix
After Fix
Description
Changed the text to fix the issue so that the gap is filled between the description and the author name, avatar and description.
Resolved issue
#3487
Summary by CodeRabbit