fix: bump codecov from v4 to v5

[anshgoyalevil]

Description

• Changes as suggested in Inconsistent - Token required because branch is protected codecov/codecov-action#1580
• and Bump codecov to v5 zigpy/workflows#26

Related issue(s)
fixes #3469

Summary by CodeRabbit

• Chores
  • Updated the codecov-action version for improved coverage report uploads in the Node.js pull request testing workflow.

[coderabbitai]

Walkthrough

The pull request modifies the Node.js pull request testing workflow by updating the version of the codecov-action used for uploading coverage reports. The previous version has been replaced with v5, while the overall structure and logic of the workflow remain unchanged. Existing conditions for executing steps based on the presence of a package.json file and other checks are preserved, ensuring the workflow continues to function as intended without the addition of new steps.

Changes

File Path	Change Summary
.github/workflows/if-nodejs-pr-testing.yml	Updated codecov-action version from e28ff129e5465... to v5

Assessment against linked issues

Objective	Addressed	Explanation
Codecov action should not fail with protected branches (#3469)	✅

Possibly related PRs

• feat: add codecov to the project #3168: This PR adds Codecov integration to the workflow, which is directly related to the changes in the main PR that update the version of the codecov-action used for uploading coverage reports.
• fix: run tests on branch pushes #3296: This PR modifies the workflow to ensure tests are executed on branch pushes, which includes uploading coverage reports to Codecov, aligning with the main PR's focus on coverage reporting.
• fix: restrict markdown tests to ubuntu runner #3318: Although this PR restricts markdown tests to the Ubuntu runner, it also involves modifications to the workflow file, which is relevant to the overall structure and functionality of the workflow in the main PR.

Suggested labels

ready-to-merge

Suggested reviewers

• derberg
• magicmatatjahu
• sambhavgupta0705
• asyncapi-bot-eve
• akshatnema

🐇 In the garden, we hop and play,
With code updates brightening our day.
A version change, so swift and neat,
Ensures our tests are quick and sweet!
Let's cheer for coverage, come what may,
For every pull request, hip-hip-hooray! 🌼

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a965dd8 and 96a5e80.

📒 Files selected for processing (1)

• .github/workflows/if-nodejs-pr-testing.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/if-nodejs-pr-testing.yml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	1c3db7f
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/675d454c55ea8e000819aaeb
😎 Deploy Preview	https://deploy-preview-3470--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[asyncapi-bot]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	36
🟢 Accessibility	98
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	33

Lighthouse ran on https://deploy-preview-3470--asyncapi-website.netlify.app/

[anshgoyalevil]

@derberg It looks like this PR isn't able to solve the issue either. Upon further research, I found that we can disable tokens in codecov for Open Source projects. This might resolve the issue (hopefully! codecov/codecov-action#1709)

Can you please do that. The setting is most probably on the page: https://app.codecov.io/account/gh/asyncapi/org-upload-token

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (55f0147) to head (1c3db7f).
Report is 9 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3470   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          575      575           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akshatnema]

@anshgoyalevil What will be changed if we are not using tokens in codecov?

[anshgoyalevil]

@akshatnema Not exactly sure. Codecov's behavior is completely ambigious. The workflow just passed without any change while a few hours back, it wasn't working.

According to what is written in the screenshot above, it looks like nothing will be changed at AsyncAPI's end.

[anshgoyalevil]

Closing this PR as we still aren't sure which option to go for. Let's keep it open-ended for future.