feat: migrate logos, slack and roadmap components to typescript #2763
Conversation
anshgoyalevil
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
components/Modal.tsx
Outdated
|
|
||
| /** | ||
| * @description Modal component. | ||
| * @param {ModalProps} props - The props for the Modal component. |
There was a problem hiding this comment.
define each prop inside the jsdoc comment. Do it for every component.
| @@ -0,0 +1,59 @@ | |||
| /** | |||
| * @description Logo for Adidas | |||
There was a problem hiding this comment.
Add props.className param in jsdocs. Do it for every component.
There was a problem hiding this comment.
ohh missed the logos.
components/slack/index.tsx
Outdated
| avatar='/img/avatars/fmvilas.webp' | ||
| name='fmvilas' | ||
| text={ | ||
| <> |
There was a problem hiding this comment.
Use span tag instead of plain <> element.
|
|
||
| import IconArrowRight from '../icons/ArrowRight'; | ||
| import Modal from '../Modal'; | ||
| /* eslint-disable import/no-cycle*/ |
There was a problem hiding this comment.
Add a extra comment on why we are adding recursion on these components.
components/roadmap/RoadmapItem.tsx
Outdated
| <svg xmlns='http://www.w3.org/2000/svg' fill='none' viewBox='0 0 24 24' strokeWidth={1.5} stroke='currentColor' className='-mt-0.5 mr-2 inline-block size-6 text-green-600'> | ||
| <path strokeLinecap='round' strokeLinejoin='round' d='M9 12.75L11.25 15 15 9.75M21 12a9 9 0 11-18 0 9 9 0 0118 0z' /> | ||
| </svg> |
There was a problem hiding this comment.
Can you please a separate functional component inside this file itself returning this icon? You can use React.ReactElement as return type for that component.
components/roadmap/RoadmapItem.tsx
Outdated
| * @param {boolean} props.isCollapsed - Whether the item is collapsed. | ||
| * @param {function} props.onClickCollapse - Function to handle click on collapse. | ||
| */ | ||
| function Pill({ |
There was a problem hiding this comment.
Create a separate file for this component as it should be handled separately, looking into the depth of code it has.
|
Made the changes |
|
/rtm |
Description