You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.
It is up to maintainers to decide if it must be addressed in one or multiple PRs.
Below are 3 different sections describing 3 different important ci/cd changes.
IMPORTANT-START
For GitHub workflows that contain This workflow is centrally managed in https://github.com/asyncapi/.github/ you do not have to perform any work. These workflows were already updated through the update in .github. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects section IMPORTANT-END
Deprecation of way data is shared between steps
Every single GitHub Action workflow that has echo "::set-output name={name}::{value}" need to be updated to follow echo "{name}={value}" >> $GITHUB_OUTPUT
We do not yet know when set-output will stop working. Previous disable date was 31.05 but now then say community needs more time.
2nd bullet point is still relevant for you even if your projects in not nodejs project
Every single workflow that uses setup-node action needs an update to follow v3 version of this action, and make sure minimum node 14 is used
Now this part is more complex. Problem with node12 is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based on node12. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For example action/checkout needs to be updated to v3.
Node12 end of support in action is probably September 27th.
Upgrade Release pipeline - in case of nodejs projects
ignore this section if your project is not nodejs project
You have 2 options. You can:
A. choose to switch to new release pipeline using instruction from asyncapi/.github#205
B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226
I definitely recommend going with A
Workflows related to release:
.github/workflows/if-nodejs-release.yml
.github/workflows/if-nodejs-version-bump.yml
.github/workflows/bump.yml
The text was updated successfully, but these errors were encountered:
derberg
added
the
area/ci-cd
Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
label
May 30, 2023
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.
It is up to maintainers to decide if it must be addressed in one or multiple PRs.
Below are 3 different sections describing 3 different important ci/cd changes.
IMPORTANT-START
For GitHub workflows that contain
This workflow is centrally managed in https://github.com/asyncapi/.github/
you do not have to perform any work. These workflows were already updated through the update in.github
. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects sectionIMPORTANT-END
Deprecation of way data is shared between steps
Every single GitHub Action workflow that has
echo "::set-output name={name}::{value}"
need to be updated to followecho "{name}={value}" >> $GITHUB_OUTPUT
We do not yet know when
set-output
will stop working. Previous disable date was 31.05 but now then say community needs more time.For more details read official article from GitHub
Deprecation of node12
v3
version of this action, and make sure minimum node 14 is usednode12
is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based onnode12
. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For exampleaction/checkout
needs to be updated to v3.Node12 end of support in action is probably September 27th.
For more details read official article from GitHub
Upgrade Release pipeline - in case of nodejs projects
You have 2 options. You can:
A. choose to switch to new release pipeline using instruction from asyncapi/.github#205
B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226
I definitely recommend going with A
Workflows related to release:
The text was updated successfully, but these errors were encountered: