Fix sidebar's color

[helios2003]

Description

The sidebar's color remains the same as the original color even when the error message is displayed.

Related issue(s)
Fixes #989

[changeset-bot]

⚠️ No Changeset found

Latest commit: 10892d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[netlify]

✅ Deploy Preview for modest-rosalind-098b67 ready!

Name	Link
🔨 Latest commit	10892d8
🔍 Latest deploy log	https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6602dd278356d50008f739c0
😎 Deploy Preview	https://deploy-preview-990--modest-rosalind-098b67.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for asyncapi-studio-design-system ready!

Name	Link
🔨 Latest commit	10892d8
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/6602dd27587a8b00089fa85e
😎 Deploy Preview	https://deploy-preview-990--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[princerajpoot20]

LGTM! 🚀 Thanks for your first PR

[netlify]

✅ Deploy Preview for studio-next ready!

Name	Link
🔨 Latest commit	10892d8
🔍 Latest deploy log	https://app.netlify.com/sites/studio-next/deploys/6602dd2702fd7200099383fc
😎 Deploy Preview	https://deploy-preview-990--studio-next.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Amzani]

LGTM

[Amzani]

/rtm

[asyncapi-bot]

Hello, @Amzani! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

[Amzani]

Hi @helios2003
Could you fix this issue: https://sonarcloud.io/component_measures?id=asyncapi_studio&pullRequest=990&metric=new_duplicated_lines_density&view=list

thanks

[helios2003]

Sure @Amzani, I will try resolving it.

[helios2003]

Hi @Amzani, from what I understand I need to refactor the last 46 lines in apps/studio-next/src/state/files.state.ts. Is that right?

[princerajpoot20]

@helios2003 , the file apps/studio-next/src/state/files.state.ts contains a duplicate line of code.
Pinging @Shurtu-gal : could you assist @helios2003 in fixing this as you have recently pushed this.

[Shurtu-gal]

The problem is that the following lines are the same and it should be as we want to introduce minimal changes while migrating. At least the states are fine as it is.

studio/apps/studio-next/src/state/files.state.ts

Lines 212 to 255 in f9fbf2d

	export interface FileStat {
	mtime: number;
	}
	export type File = {
	uri: string;
	name: string;
	content: string;
	from: 'storage' | 'url' | 'base64';
	source?: string;
	language: 'json' | 'yaml';
	modified: boolean;
	stat?: FileStat;
	}
	export type FilesState = {
	files: Record<string, File>;
	}
	export type FilesActions = {
	updateFile: (uri: string, file: Partial<File>) => void;
	}
	export const filesState = create<FilesState & FilesActions>(set => ({
	files: {
	asyncapi: {
	uri: 'asyncapi',
	name: 'asyncapi',
	content: schema,
	from: 'storage',
	source: undefined,
	language: schema.trimStart()[0] === '{' ? 'json' : 'yaml',
	modified: false,
	stat: {
	mtime: (new Date()).getTime(),
	}
	}
	},
	updateFile(uri: string, file: Partial<File>) {
	set(state => ({ files: { ...state.files, [String(uri)]: { ...state.files[String(uri)] || {}, ...file } } }));
	}
	}));
	export const useFilesState = filesState;

studio/apps/studio/src/state/files.state.ts

Lines 212 to 255 in f9fbf2d

	export interface FileStat {
	mtime: number;
	}
	export type File = {
	uri: string;
	name: string;
	content: string;
	from: 'storage' | 'url' | 'base64';
	source?: string;
	language: 'json' | 'yaml';
	modified: boolean;
	stat?: FileStat;
	}
	export type FilesState = {
	files: Record<string, File>;
	}
	export type FilesActions = {
	updateFile: (uri: string, file: Partial<File>) => void;
	}
	export const filesState = create<FilesState & FilesActions>(set => ({
	files: {
	asyncapi: {
	uri: 'asyncapi',
	name: 'asyncapi',
	content: schema,
	from: 'storage',
	source: undefined,
	language: schema.trimStart()[0] === '{' ? 'json' : 'yaml',
	modified: false,
	stat: {
	mtime: (new Date()).getTime(),
	}
	}
	},
	updateFile(uri: string, file: Partial<File>) {
	set(state => ({ files: { ...state.files, [String(uri)]: { ...state.files[String(uri)] || {}, ...file } } }));
	}
	}));
	export const useFilesState = filesState;

@Amzani is there any way this rule can be disabled 🤔

[Amzani]

@helios2003 @Shurtu-gal as we are migrating code to studio-next we can add studio-next directory in .sonarcloud.properties / sonar.cpd.exclusions

[helios2003]

@Shurtu-gal should I add this as a part of the PR or the change should be done by the maintainer itself?

[Shurtu-gal]

You can do it in this PR itself.

[helios2003]

@Amzani, @Shurtu-gal the changes have been made.

[Shurtu-gal]

@Amzani, @Shurtu-gal the changes have been made.

Great!! Thanks 🤗

[princerajpoot20]

Great work! @helios2003

[KhudaDad414]

@Amzani @Shurtu-gal what about adding studio to the Sonar exception list? Since studio-next is going to see a lot of activity and by ignoring duplicates in studio we can make sure the studio-next is duplicate free.

[Shurtu-gal]

@KhudaDad414 it is already there I believe.

[helios2003]

Maintainers, if the PR is fine, can it be merged?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[princerajpoot20]

LGTM

[Shurtu-gal]

/rtm

[Amzani]

LGTM

[KhudaDad414]

/rtm

[KhudaDad414]

this PR did not result in a release because it did not contain a changeset. #990 (comment)

@Amzani now I understand your frustration. 🤦