Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs and split panels like in VSC #167

Closed
magicmatatjahu opened this issue Nov 2, 2021 · 10 comments
Closed

Tabs and split panels like in VSC #167

magicmatatjahu opened this issue Nov 2, 2021 · 10 comments
Labels
enhancement New feature or request stale

Comments

@magicmatatjahu
Copy link
Member

At the moment we have only two main panels + navigation: navigation on the left, and the panel with the editor (middle) and the panel for displaying the documentation (and visualiser) on the right. This is enough for now because we don't have the ability to add plugins (aka modules) to our studio. However the current solution will not be easy to use new things and does not give a really big freedom for the user (in the future, when we will add more stuff to the Studio).

A very good solution would be to use the idea like in VSC - we have navigation on the left, which opens our content on the right in the form of tabs and split panels, where we can open two parallel panels, for example editor + html preview or 2 editors.

Each panel would have its own tabs and the content in the navigation would change depending on where the user focuses his/her attention, i.e. in which editor he/she changes the value - just like in the VSC. We can then, for example, add a context for panel/tab like in our CLI, which would specify which specification to render to html etc.

What do you think?

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Nov 2, 2021
@boyney123
Copy link
Contributor

we have navigation on the left, which opens our content on the right in the form of tabs and split panels, where we can open two parallel panels, for example editor + html preview or 2 editors.

So to verify you are talking about the ability to click on the navigation items, which will launch new tabs. So if I click on the editor multiple times I could have multiple editors going on at once, with different AsyncAPI files?

Sounds interesting, I'm trying to vision what features this will allow us to implement? I imagine it would complicate the codebase a fair bit with dynamic panels and tabs (as many as you want) and a developer experince to see things like docs + visualisation stuff per file, (not sure how that would work).


Also, I know this was generated from the idea of #158 , I wonder if we can deliver the value of #158 without waiting for this panel/tab solution? Thoughts?

@magicmatatjahu
Copy link
Member Author

So to verify you are talking about the ability to click on the navigation items, which will launch new tabs. So if I click on the editor multiple times I could have multiple editors going on at once, with different AsyncAPI files?

Yes :) I have idea to support also filesystem (with cli connection) to show files in the given folder and people will be able to have multiple tabs with multiple files like in normal VSC.

Sounds interesting, I'm trying to vision what features this will allow us to implement? I imagine it would complicate the codebase a fair bit with dynamic panels and tabs (as many as you want) and a developer experince to see things like docs + visualisation stuff per file, (not sure how that would work).

I don't think so that it will introduce more complexity to our codebase, because we should go with that with some state shape to know what exactly we show and where - how many panels with which panels. I will make some POC to see my idea.

and a developer experince to see things like docs + visualisation stuff per file, (not sure how that would work).

This is the plan to make it possible :)

Also, I know this was generated from the idea of #158 , I wonder if we can deliver the value of #158 without waiting for this panel/tab solution? Thoughts?

The studio in on development process, so we can make "breaking" changes. We can go with your solution (but not as new page, but content which will be rendered in place of editor and preview - next to navigation) and then if we have panels and tabs then we will change your solution to tab :) Do you agree or do you have another solution?

@boyney123
Copy link
Contributor

Thanks @magicmatatjahu .

The studio in on development process, so we can make "breaking" changes. We can go with your solution (but not as new page, but content which will be rendered in place of editor and preview - next to navigation) and then if we have panels and tabs then we will change your solution to tab :) Do you agree or do you have another solution?

Yeah I think that sounds good to me, I made changes over on #147 , if you wanted to take a look, let me know what you think? I think I understand what you meant, when pressing the new icon it will take over the main content section.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 13, 2022
@mcturco mcturco removed the stale label Jul 13, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 15, 2023
@fmvilas
Copy link
Member

fmvilas commented Mar 28, 2023

Isn't it already in place, @magicmatatjahu? Can we close it?

@github-actions github-actions bot removed the stale label Mar 30, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 29, 2023
@Amzani
Copy link
Collaborator

Amzani commented Jan 18, 2024

As we now have #634 we can close this.

@Amzani Amzani closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants