-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify all referencing mechanisms in v3 #829
Comments
I'm in favor of using |
I agree. Having it unique would be a good idea. Contra:
operations:
sendUserSignedUp:
action: send
channel:
$ref: '#/message/xyz' <--- should be /channel/ not /message/ But there for we have schema validator to point out mistakes like this. Pro:
|
let's do |
I agree let's use $ref everywhere. Side effect this way makes it easier for tooling as well.
That would almost always be the case (when using references) but as this is always caught by validators and parsers, I am not sure we can even say it's a con 😄 |
/progress 60 PR is in place now: #852. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
I cannot seem to find the changes in the parser, @fmvilas are you sure this change is complete? I have the changes in for the spec #852 and JSON Schema files asyncapi/spec-json-schemas#316. |
Yes, it's missing. I created an issue here: asyncapi/parser-js#746. Thanks for the pointer! |
Spin off from this conversation: #663 (comment).
Summary
We use different referencing mechanisms in the spec:
$ref
: pretty much everywhereThis issue is to discuss if we should unify all of them and how.
The text was updated successfully, but these errors were encountered: