Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add /parse path #83

Merged
merged 3 commits into from
Apr 5, 2022
Merged

feat: add /parse path #83

merged 3 commits into from
Apr 5, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • Add /parse path
  • Updated openapi.yaml
  • Write controller
  • Write tests

Related issue(s)
Resolves #81

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Mar 30, 2022
BOLT04
BOLT04 reviewed Apr 3, 2022
View reviewed changes
Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good @magicmatatjahu 👍, I just left some comments for us to discuss 🙂

openapi.yaml Outdated Show resolved Hide resolved
openapi.yaml Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
src/controllers/parse.controller.ts Show resolved Hide resolved
@magicmatatjahu
Copy link
Member Author

@BOLT04 Hi! Thanks for the review! I push your suggestions and I answered to comments. If you have time, check it out, thanks! :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

BOLT04
BOLT04 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @magicmatatjahu! 👋🏼
This PR is not up to date with the base branch and can't be merged.
You can add comment to this PR with text: /autoupdate or /au. This way you ask our bot to perform regular updates for you. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Otherwise the only option that you have is to manually update your branch with latest version of the base branch.
Thanks 😄

@asyncapi-bot asyncapi-bot merged commit cea6d1a into asyncapi:master Apr 5, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magicmatatjahu magicmatatjahu deleted the feat/parse branch April 5, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BOLT04 BOLT04 BOLT04 approved these changes

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add implementation for /parse path
3 participants
@magicmatatjahu @asyncapi-bot @BOLT04