fix: use node image as base to ensure version range #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@smoya Thanks for PR! I understand you tested the image on your machine? |
❯ docker build --no-cache --tag asyncapi/server-api .
[+] Building 153.4s (16/16) FINISHED
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 37B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 34B 0.0s
=> [internal] load metadata for docker.io/library/node:14-alpine3.14 2.1s
=> [auth] library/node:pull token for registry-1.docker.io 0.0s
=> CACHED [base 1/2] FROM docker.io/library/node:14-alpine3.14@sha256:8c93166ecea91d8384d9f1768ceaca1cd8bc22c1eb13005cecfb491588bd8169 0.0s
=> [internal] load build context 0.0s
=> => transferring context: 4.60kB 0.0s
=> [base 2/2] RUN apk add --update nghttp2 1.2s
=> [build 1/4] WORKDIR /app 0.0s
=> [build 2/4] COPY . . 0.1s
=> [build 3/4] RUN rm package-lock.json; npm install 93.3s
=> [build 4/4] RUN npm run build:prod 12.5s
=> [release 2/5] COPY --from=build /app/dist ./dist 0.0s
=> [release 3/5] COPY --from=build /app/package* ./ 0.4s
=> [release 4/5] RUN npm ci --only=production 29.5s
=> [release 5/5] COPY openapi.yaml ./ 0.0s
=> exporting to image 10.3s
=> => exporting layers 10.3s
=> => writing image sha256:1ce56098b22c6149a662de7d0e0f9aaca1910f615794d40eca5d082d35999576 0.0s
=> => naming to docker.io/asyncapi/server-api 0.0s
❯ docker run -p 80:80 asyncapi/server-api
> @asyncapi/[email protected] start:prod /app
> NODE_ENV=production node dist/server.js
2022-02-14 12:27:12 info: =================================
2022-02-14 12:27:12 info: = ENV: production
2022-02-14 12:27:12 info: = 🚀 AsyncAPI Server API listening on the port 80
2022-02-14 12:27:12 info: =================================And ❯ curlie -X POST 'localhost/v1/validate' -H "Content-Type: application/json" -d '{"asyncapi":{"asyncapi":"2.2.0","info":{"title":"Account Service","version":"1.0.0","description":"This service is in charge of processing user signups"},"channels":{"user/signedup":{"subscribe":{"message":{"$ref":"#/components/messages/UserSignedUp"}}}},"components":{"messages":{"UserSignedUp":{"payload":{"type":"object","properties":{"displayName":{"type":"string","description":"Name of the user"},"email":{"type":"string","format":"email","description":"Email of the user"}}}}}}}}'
HTTP/1.1 204 No Content
X-Powered-By: Express
Vary: Origin
Date: Mon, 14 Feb 2022 12:33:42 GMT
Connection: keep-alive
Keep-Alive: timeout=5 |
magicmatatjahu
approved these changes
Feb 14, 2022
|
/rtm |
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the current CI error on release: https://github.com/asyncapi/server-api/runs/5158849217?check_suite_focus=true.
The issue behind it is that alpine version got both
nodejsandnpmupdated, so the specified version (14.18.1-r0) is no longer available.In order to avoid the same problem in the future, we could either install both
nodejsandnpmpackages without version modifier (not sure which version it will be installed if they keep updating it), use a fixed repository for installing those versions or rather, (the solution I chose) stick withnodeDocker image instead ofalpinebut with thealpineversion tag:14-alpine3.14, so we ensure any node version installed would be14.x.x.Btw, I added
fix:prefix to force a release because the previous one failed when publishing the Docker image to Docker hub.