feat: enable push to NPM registry #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
BOLT04,
magicmatatjahu and
asyncapi-bot-eve
as code owners
|
|
@BOLT04 @magicmatatjahu Unblocking CI ASAP requires me to bypass the PR protection requirements so I can merge without your +1. If you believe this should not be here, please open a PR with the revert. |
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We never published our NPM package to NPM registry. As it is the first time we do, we need to specify that the package (scoped package) is public, otherwise it will be considered as restricted and our push command in CI will fail, as in here.
More info: https://docs.npmjs.com/creating-and-publishing-scoped-public-packages#publishing-scoped-public-packages
We have several ways of doing this, we could just publish manually our first version to NPM, but that's not pretty cool since we would need to ask someone with the credentials (NPM TOKEN) to do.
Instead, we can just add this
.npmrcfile with the right config to tell NPM this is a public scoped package. Alternatively, we could add a config for semantic-release, but I believe this should be in the.npmrcsince it is purely related to NPM.