Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for tags field on Server model #565

Merged
merged 2 commits into from
Sep 22, 2022
Merged

feat: add support for tags field on Server model #565

merged 2 commits into from
Sep 22, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Jun 17, 2022 •
edited
Loading

Description

This PR adds support for Tags on Server model. They can be used for providing metadata, including the environment such as production, development, etc.

Related issue(s)
asyncapi/spec#654

@smoya smoya mentioned this pull request Jun 17, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fmvilas
fmvilas previously approved these changes Jul 18, 2022
View reviewed changes
@char0n char0n mentioned this pull request Sep 20, 2022
Closed
61 tasks
@smoya
Copy link
Member Author

smoya commented Sep 20, 2022

@fmvilas @magicmatatjahu @jonaslagoni @derberg a last review so we can include this into 2.5 finally?

@smoya smoya changed the base branch from master to next-major September 20, 2022 14:12
@smoya smoya changed the base branch from next-major to master September 20, 2022 14:12
@smoya smoya dismissed fmvilas’s stale review September 20, 2022 14:12

The base branch was changed.

@smoya smoya changed the base branch from master to next-spec September 20, 2022 14:16
@smoya
Copy link
Member Author

smoya commented Sep 22, 2022

@derberg would you mind doing a review of this so we can include it in 2.5? Thanks!

@char0n
Copy link
Contributor

char0n commented Sep 22, 2022

@smoya can you please incorporate latest @asyncapi/spec pre-release into your PR? THanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n
Copy link
Contributor

char0n commented Sep 22, 2022

Looking good. Incorporating this into 2.5.0 release. Thanks @smoya! Merging.

@char0n
Copy link
Contributor

char0n commented Sep 22, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit b9e5401 into asyncapi:next-spec Sep 22, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.17.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@smoya @char0n @asyncapi-bot @fmvilas @derberg @magicmatatjahu