Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate import keyword in Kotlin generator example #2115

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Manancode
Copy link
Contributor

@Manancode Manancode commented Oct 26, 2024

Description

When using showTypeMappingExample in the Kotlin generator, the example code includes a import keyword in the dependency string which causes the generated code to have an invalid double import statement.

Related Issue

fixes #2107

Checklist

  • [✅] The code follows the project's coding standards and is properly linted (npm run lint).
  • [✅] All tests pass successfully locally.(npm run test).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 3bb4214
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/671cc8272f61a70008d9851b
😎 Deploy Preview https://deploy-preview-2115--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Oct 26, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11531186065

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.314%

Totals Coverage Status
Change from base Build 11517599539: 0.0%
Covered Lines: 6002
Relevant Lines: 6333

💛 - Coveralls

@jonaslagoni
Copy link
Member

/rtm

@jonaslagoni jonaslagoni merged commit 8c3c152 into asyncapi:master Oct 29, 2024
28 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants