Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Scala generator #1665

Merged
merged 8 commits into from
Dec 23, 2023

Conversation

artur-ciocanu
Copy link
Collaborator

Description

  • Adding Scala generator

Related issue(s)
Resolves #1664

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit ad94e42
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6586db8472a65b00087bb2d0

@artur-ciocanu
Copy link
Collaborator Author

The PR is WIP ...

@artur-ciocanu artur-ciocanu changed the title Adding Scala generator scaffolding feat: Adding Scala generator Dec 16, 2023
@coveralls
Copy link

coveralls commented Dec 16, 2023

Pull Request Test Coverage Report for Build 7308436291

  • 256 of 284 (90.14%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.262%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/scala/ScalaDependencyManager.ts 4 5 80.0%
src/generators/scala/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/scala/constrainer/EnumConstrainer.ts 29 30 96.67%
src/generators/scala/presets/DescriptionPreset.ts 18 19 94.74%
src/generators/scala/ScalaGenerator.ts 50 52 96.15%
src/generators/scala/ScalaRenderer.ts 20 23 86.96%
src/generators/scala/ScalaConstrainer.ts 44 48 91.67%
src/generators/scala/index.ts 7 14 50.0%
src/generators/scala/ScalaFileGenerator.ts 3 11 27.27%
Totals Coverage Status
Change from base Build 7304248248: -0.2%
Covered Lines: 5862
Relevant Lines: 6192

💛 - Coveralls

@artur-ciocanu artur-ciocanu changed the title feat: Adding Scala generator feat: adding Scala generator Dec 16, 2023
@jonaslagoni
Copy link
Member

Let me know if you need anything from me @artur-ciocanu 🤙 Looking forward to having this!

@jonaslagoni
Copy link
Member

@artur-ciocanu you can ignore sonar duplication warning

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing left to do as I see is adding simple generate example: https://github.com/asyncapi/modelina/tree/master/examples/generate-java-models

There is a template you can copy and change 🙂

package.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

7.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@artur-ciocanu
Copy link
Collaborator Author

@jonaslagoni it seems that I have covered everything that is required for Scala code gen. Once this PR is out, I'll add some JSON serialization preset and Jakarta validation preset.

Let me know your thought and if there is anything else required.

Thank you!

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @artur-ciocanu, thanks for taking the time to provide it 🤙 Got a couple of small things that needs to be added, but Ill create issues after, not required to merge 😄

Also, do you want to become the codeowner of the scala generator, or are you only looking to donate it? ✌️

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 26a3953 into asyncapi:master Dec 23, 2023
15 of 16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member

@all-contributors please add @artur-ciocanu for code, example, docs, test

Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @artur-ciocanu! 🎉

@artur-ciocanu
Copy link
Collaborator Author

Awesome @artur-ciocanu, thanks for taking the time to provide it 🤙 Got a couple of small things that needs to be added, but Ill create issues after, not required to merge 😄

Also, do you want to become the codeowner of the scala generator, or are you only looking to donate it? ✌️

@jonaslagoni I can be a code owner, I would like to get rid of my "internal" fork and just maintain the official Modelina version.

Thanks for merging it!

@artur-ciocanu artur-ciocanu deleted the scala-generator branch December 23, 2023 13:46
@jonaslagoni
Copy link
Member

@jonaslagoni I can be a code owner, I would like to get rid of my "internal" fork and just maintain the official Modelina version.

Awesome, thanks for doing it! Added a PR to add you 🤙 #1686

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala generator
4 participants