-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript: marshalling of additionalProperties
properties is naive
#1435
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
I was using |
Might be an issue with the additional properties then 🤔 |
Ill have a look once I get back next week 🙂 |
@duckling69 maybe you wanna have a go at this issue? |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Tracing this back to dictionary types and unions, all dictionary types regardless of whether it's for additionalProperties or something else. Working on a fix |
Describe the bug
It looks like nested models get a simple
JSON.stringify
treatment and thus result in stringifying the internal/private (_foo
) props, rather than public names.How to Reproduce
additionalProperties
option. I am using a JSON Schema for GitHub Actions Workflows.modelType: 'class'
andmarshalling: true
optionsExpected behavior
Probably needs to call
.marhsal()
if it is a known model objectThe text was updated successfully, but these errors were encountered: